This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] Cleanup MIPS preconfigure script
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Steve Ellcey <sellcey at mips dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, <libc-alpha at sourceware dot org>, <matthew dot fortune at imgtec dot com>, Catherine Moore <clm at codesourcery dot com>
- Date: Tue, 9 Sep 2014 19:21:39 +0100
- Subject: Re: [PATCH] Cleanup MIPS preconfigure script
- Authentication-results: sourceware.org; auth=none
- References: <6b5ce132-2a69-4ee9-aaa5-d07792e72b50 at BAMAIL02 dot ba dot imgtec dot org> <alpine dot DEB dot 1 dot 10 dot 1409042322000 dot 27075 at tp dot orcam dot me dot uk> <1409871127 dot 2740 dot 76 dot camel at ubuntu-sellcey> <alpine dot DEB dot 1 dot 10 dot 1409050002390 dot 27075 at tp dot orcam dot me dot uk> <1409948236 dot 2740 dot 110 dot camel at ubuntu-sellcey> <Pine dot LNX dot 4 dot 64 dot 1409052152480 dot 20739 at digraph dot polyomino dot org dot uk> <1410279506 dot 2740 dot 158 dot camel at ubuntu-sellcey> <alpine dot DEB dot 1 dot 10 dot 1409091806340 dot 27075 at tp dot orcam dot me dot uk> <1410282834 dot 2740 dot 159 dot camel at ubuntu-sellcey>
On Tue, 9 Sep 2014, Steve Ellcey wrote:
> > Hmm, I think the capitalisation is weird here, why not:
> > + as_fn_error $? "MIPS16 is only supported with the o32 ABI." "$LINENO" 5
> > ?
> I already checked it in but I can go back and tweak the capitalization
> if you want.
That would be my preference, thanks.
While historically across the toolchain we don't have a very good record
of keeping the spelling of such stuff correct, I think we really ought to
keep it consistent with published documentation. Especially in messages
shown to the user or external documentation, although it won't hurt doing
that everywhere including internal documentation, debug messages and
comments, to make getting good habits easier if nothing else.
Inconsistent or bad spelling gives users the impression code itself is
sloppy and that is something we'd rather avoid. Having also made sure
code actually is not sloppy that is of course, that we strive to achieve
through our review process.