This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Cleanup MIPS preconfigure script

On Tue, 9 Sep 2014, Steve Ellcey wrote:

> >  Hmm, I think the capitalisation is weird here, why not:
> > 
> > +	as_fn_error $? "MIPS16 is only supported with the o32 ABI." "$LINENO" 5
> > 
> > ?
> I already checked it in but I can go back and tweak the capitalization
> if you want.

 That would be my preference, thanks.

 While historically across the toolchain we don't have a very good record 
of keeping the spelling of such stuff correct, I think we really ought to 
keep it consistent with published documentation.  Especially in messages 
shown to the user or external documentation, although it won't hurt doing 
that everywhere including internal documentation, debug messages and 
comments, to make getting good habits easier if nothing else.  

 Inconsistent or bad spelling gives users the impression code itself is 
sloppy and that is something we'd rather avoid.  Having also made sure 
code actually is not sloppy that is of course, that we strive to achieve 
through our review process.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]