This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix crashes on invalid input in IBM gconv modules [BZ #17325]


On 08/29/2014 11:54 PM, Roland McGrath wrote:
Florian Weimer <fweimer@redhat.com> writes:

+	if (__builtin_expect (rp2->start == 0xffff, 0)			      \

Please use either this

+	if (__builtin_expect (ch == 0xffff, 0)				      \

or this consistently.

Use neither.  Use __glibc_{un,}likely consistently.

I would like to do this in a future cleanup across all gconv modules, after the 2.20 release. For this patch, I went with the existing style in the changed files. This also simplifies backporting.

--
Florian Weimer / Red Hat Product Security


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]