This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix crashes on invalid input in IBM gconv modules [BZ #17325]

From: Florian Weimer <fweimer at redhat dot com>
To: Roland McGrath <roland at hack dot frob dot com>, Andreas Schwab <schwab at linux-m68k dot org>
Cc: GNU C Library <libc-alpha at sourceware dot org>, azanella at linux dot vnet dot ibm dot com
Date: Sat, 30 Aug 2014 12:26:09 +0200
Subject: Re: [PATCH] Fix crashes on invalid input in IBM gconv modules [BZ #17325]
Authentication-results: sourceware.org; auth=none
References: <54006E57 dot 8030800 at redhat dot com> <87y4u7o1yr dot fsf at igel dot home> <20140829215448 dot 6C4972C3A30 at topped-with-meat dot com>

On 08/29/2014 11:54 PM, Roland McGrath wrote:

Florian Weimer <fweimer@redhat.com> writes:

+	if (__builtin_expect (rp2->start == 0xffff, 0)			      \


Please use either this

+	if (__builtin_expect (ch == 0xffff, 0)				      \


or this consistently.


Use neither.  Use __glibc_{un,}likely consistently.

I would like to do this in a future cleanup across all gconv modules,after the 2.20 release. For this patch, I went with the existing stylein the changed files. This also simplifies backporting.


--
Florian Weimer / Red Hat Product Security

References:
- [PATCH] Fix crashes on invalid input in IBM gconv modules [BZ #17325]
  - From: Florian Weimer
- Re: [PATCH] Fix crashes on invalid input in IBM gconv modules [BZ #17325]
  - From: Andreas Schwab
- Re: [PATCH] Fix crashes on invalid input in IBM gconv modules [BZ #17325]
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]