This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v1.1] __gconv_translit_find: Actually append ".so" to module name [BZ #17187]
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Allan McRae <allan at archlinux dot org>, Florian Weimer <fweimer at redhat dot com>, Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 26 Aug 2014 10:33:20 -0400
- Subject: Re: [PATCH v1.1] __gconv_translit_find: Actually append ".so" to module name [BZ #17187]
- Authentication-results: sourceware.org; auth=none
- References: <53CD0F15 dot 3030806 at redhat dot com> <53F62D4F dot 3040702 at redhat dot com> <20140826063513 dot GB26743 at spoyarek dot pnq dot redhat dot com> <53FC58D8 dot 8060409 at redhat dot com> <53FC6E2C dot 3070900 at archlinux dot org>
On 08/26/2014 07:23 AM, Allan McRae wrote:
> On 26/08/14 19:52, Florian Weimer wrote:
>> On 08/26/2014 08:35 AM, Siddhesh Poyarekar wrote:
>>
>>> I think this fix is fine (except a minor nit below), but it would be
>>
>> Thanks.
>>
>>> good if another maintainer also verifies that it won't break anything.
>>> Also, Allan needs to ack it for 2.20. I am going to put the patch in
>>> rawhide today anyway, so I'll report back if there are any issues; I
>>> don't expect any though.
>>
>> Okay, I will reword the comment.
>>
>> Allan, is this okay for 2.20/current master?
>>
>
> I'd like the "if another maintainer also verifies that it won't break
> anything" to be enacted. My best guess is that it is fine and given
> there is an exploit it should go in, but I am not confident enough about
> lack of side effects.
>
> Can someone else give this an ack? Roland, Carlos, Joseph, etc?
>
> Once that is done, it is fine to commit to master.
I'm reviewing.
c.