This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [all-arch][PATCH 00/19] Fix -Wundef warning in SHLIB_COMPAT
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 22 Aug 2014 16:01:21 +0000
- Subject: Re: [all-arch][PATCH 00/19] Fix -Wundef warning in SHLIB_COMPAT
- Authentication-results: sourceware.org; auth=none
- References: <1408618663-2281-1-git-send-email-siddhesh at redhat dot com> <20140822045700 dot GE16835 at spoyarek dot pnq dot redhat dot com>
On Fri, 22 Aug 2014, Siddhesh Poyarekar wrote:
> - m68k-linux-gnu:
> - alpha-linux-gnu:
>
> Patch 20/20 causes these to export unwinder symbols conditionalized in
> elf/Versions using the EXPORT_UNWIND_FIND_FDE macro. Upon looking
> deeper, it looks like they ought to have exported the symbols after
> all since both architectures set libc_cv_gcc_unwind_find_fde to yes in
> their configure fragments.
Do you mean some previous patch in the series broke those exports and
patch 20/20 restored them? The exports appear in libc.abilist so I
presume are currently working as they should, or at least were working
recently. General principles of bisectability mean things should be
designed to stay working after each patch rather than patch 20 fixing
something broken by an earlier patch.
(I think this series is far too big and risky to go in during the freeze,
as illustrated by these architecture-specific issues being found; it would
much better go in after the release. It's possible the *other* -Wundef
warnings have simple enough fixes to go in during the freeze.)
--
Joseph S. Myers
joseph@codesourcery.com