This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Revert to defining __extern_inline only for g++-4.3+
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: <libc-alpha at sourceware dot org>, <jakub at redhat dot com>
- Date: Wed, 13 Aug 2014 20:51:22 +0000
- Subject: Re: [PATCH] Revert to defining __extern_inline only for g++-4.3+
- Authentication-results: sourceware.org; auth=none
- References: <20140813182334 dot GA3507 at spoyarek dot pnq dot redhat dot com>
On Wed, 13 Aug 2014, Siddhesh Poyarekar wrote:
> Hi,
>
> The check for only __GNUC_STDC_INLINE__ and __GNUC_GNU_INLINE__ may
> not be sufficient since those flags were added during initial support
> for C99 inlining semantics. There is also a problem with always
> defining __extern_inline and __extern_always_inline, since it enables
> inline wrapper functions even when GNU inlining semantics are not
> guaranteed. This, along with the possibility of such wrappers using
> redirection (btowc for example) could result in compiler generating an
> infinitely recusrive call to the function.
Are you describing a problem that was user-visible in a glibc release? (I
guess so, since you don't mention any post-2012 commits as having caused a
regression.) What specifically is the problem (building what, with what
compiler versions)? A bug report in glibc Bugzilla is needed if it was
user-visible in a release.
--
Joseph S. Myers
joseph@codesourcery.com