This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Handle possible vararg promotion of mode_t in open and friends
- From: Rasmus Villemoes <rv at rasmusvillemoes dot dk>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: libc-alpha at sourceware dot org, neleai at seznam dot cz
- Date: Sun, 03 Aug 2014 14:25:12 +0200
- Subject: Re: [PATCH v2] Handle possible vararg promotion of mode_t in open and friends
- Authentication-results: sourceware.org; auth=none
- References: <20140516204041 dot GB17252 at domone dot podge> <1400538110-7066-1-git-send-email-rv at rasmusvillemoes dot dk> <2192491 dot OcgUEQ9ZWL at vapier>
Mike Frysinger <vapier@gentoo.org> writes:
> On Tue 20 May 2014 00:21:50 Rasmus Villemoes wrote:
>> + mode = va_arg (ap, __typeof__(+(mode_t)0));
>
> seems like this should be a define in a private header rather than copy &
> pasted in every call site
Good idea. I'm not too familiar with glibc's internal organization; in
particular, I don't know which headers are private and which are
not. Could you suggest a specific header file to put this in?
Thanks,
Rasmus