This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Use statfs64() in shm_open() and posix_getpt().

From: Mike Frysinger <vapier at gentoo dot org>
To: libc-alpha at sourceware dot org
Cc: Andreas Schwab <schwab at linux-m68k dot org>, OndÅej BÃlka <neleai at seznam dot cz>, Peter TB Brett <peter at peter-b dot co dot uk>
Date: Sat, 02 Aug 2014 10:30:33 -0400
Subject: Re: [PATCH] Use statfs64() in shm_open() and posix_getpt().
Authentication-results: sourceware.org; auth=none
References: <1397373978-17449-1-git-send-email-peter at peter-b dot co dot uk> <20140413111541 dot GA13260 at domone dot podge> <87wqetkviy dot fsf at igel dot home>

On Sun 13 Apr 2014 19:07:49 Andreas Schwab wrote:
> OndÅej BÃlka <neleai@seznam.cz> writes:
> > On Sun, Apr 13, 2014 at 09:44:11AM +0200, Andreas Schwab wrote:
> >> Peter TB Brett <peter@peter-b.co.uk> writes:
> >> > +	      || (statfs64 (_PATH_DEVPTS, &fsbuf) == 0
> >> 
> >> This is not namespace clean, and will introduce a PLT call (you did run
> >> make check?).
> > 
> > According to Carlos its part of librt.so
> 
> ??? posix_openpt is part of libc.

right, posix_openpt is part of libc, but shm_open is part of librt.  so the 
former should use __statfs64 to avoid the PLT while the latter should use 
statfs64.

so can we get an updated patch now ? :)
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Follow-Ups:
- Re: [PATCH] Use statfs64() in shm_open() and posix_getpt().
  - From: Joseph S. Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]