This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix Wundef warning for MEMCPY_OK_FOR_FWD_MEMMOVE

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: Roland McGrath <roland at hack dot frob dot com>
Cc: libc-alpha at sourceware dot org
Date: Fri, 27 Jun 2014 14:51:09 +0530
Subject: Re: [PATCH] Fix Wundef warning for MEMCPY_OK_FOR_FWD_MEMMOVE
Authentication-results: sourceware.org; auth=none
References: <20140626185412 dot GA1826 at spoyarek dot pnq dot redhat dot com> <20140626190423 dot 572732C3993 at topped-with-meat dot com>

On Thu, Jun 26, 2014 at 12:04:23PM -0700, Roland McGrath wrote:
> That only helps x86_64 and not anybody else using that file (whether
> directly by sysdeps selection or by #include).  I think memcopy.h should
> be required to define that one way or the other.  Then we can have a
> default in sysdeps/generic/memcopy.h.

Wouldn't that not catch cases where one forgets to define the macro
and inherits the default?

Siddhesh

Attachment: pgpAP8wYb3xHd.pgp
Description: PGP signature

Follow-Ups:
- Re: [PATCH] Fix Wundef warning for MEMCPY_OK_FOR_FWD_MEMMOVE
  - From: Will Newton

References:
- [PATCH] Fix Wundef warning for MEMCPY_OK_FOR_FWD_MEMMOVE
  - From: Siddhesh Poyarekar
- Re: [PATCH] Fix Wundef warning for MEMCPY_OK_FOR_FWD_MEMMOVE
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]