This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 0/6 rth/hpt] hp-timing cleanups
- From: Will Newton <will dot newton at linaro dot org>
- To: Richard Henderson <rth at twiddle dot net>
- Cc: libc-alpha <libc-alpha at sourceware dot org>, Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>, David Miller <davem at davemloft dot net>, Marcus Shawcroft <marcus dot shawcroft at arm dot com>
- Date: Thu, 26 Jun 2014 09:53:21 +0100
- Subject: Re: [PATCH 0/6 rth/hpt] hp-timing cleanups
- Authentication-results: sourceware.org; auth=none
- References: <1403735086-21797-1-git-send-email-rth at twiddle dot net>
On 25 June 2014 23:24, Richard Henderson <rth@twiddle.net> wrote:
> I started to add the hp-timing.h file for aarch64, and noticed that
> most of the complicated bits aren't actually used, and there's large
> amounts of boiler-plate between the copies.
>
> This patch set first deletes all the stuff that isn't used, then
> creates a hp-timing-common.h that the ports can share.
>
> I've tested this on i686, x86_64, ppc64, aarch64. I've not tried
> ppc32 or sparc.
>
> Ok?
>
>
> Richard Henderson (6):
> powerpc: Remove dummy hp-timing.h
> Removing HP_TIMING_ZERO as unused
> Removing HP_TIMING_ACCUM as unused
> Remove HP_TIMING_DIFF_INIT and dl_hp_timing_overhead
> Unify hp-timing implementations
> aarch64: Add hp-timing.h
This looks like a really nice cleanup. However it would be nice to
also squash the HP_SMALL_TIMING_AVAIL warnings at the same time. Steve
Ellcey posted a similar patch a couple of months back:
http://patchwork.sourceware.org/patch/773/
You should see the warnings on ARM or AArch64 prior to your final patch.
> benchtests/bench-string.h | 2 -
> benchtests/bench-timing.h | 7 +-
> elf/rtld.c | 3 -
> .../{i386/i686/hp-timing.c => aarch64/hp-timing.h} | 25 ++++-
> sysdeps/alpha/hp-timing.h | 73 +------------
> sysdeps/generic/hp-timing-common.h | 62 +++++++++++
> sysdeps/generic/hp-timing.h | 45 +-------
> sysdeps/generic/ldsodefs.h | 5 -
> sysdeps/i386/i686/Makefile | 5 -
> sysdeps/i386/i686/hp-timing.h | 117 +--------------------
> sysdeps/ia64/Makefile | 2 -
> sysdeps/ia64/hp-timing.c | 23 ----
> sysdeps/ia64/hp-timing.h | 101 +-----------------
> sysdeps/powerpc/powerpc32/hp-timing.h | 81 --------------
> sysdeps/powerpc/powerpc32/power4/hp-timing.c | 24 -----
> sysdeps/powerpc/powerpc32/power4/hp-timing.h | 97 +----------------
> sysdeps/powerpc/powerpc64/Makefile | 5 -
> sysdeps/powerpc/powerpc64/hp-timing.c | 24 -----
> sysdeps/powerpc/powerpc64/hp-timing.h | 96 +----------------
> sysdeps/sparc/sparc32/sparcv9/Makefile | 5 -
> sysdeps/sparc/sparc32/sparcv9/hp-timing.c | 23 ----
> sysdeps/sparc/sparc32/sparcv9/hp-timing.h | 53 +---------
> sysdeps/sparc/sparc64/Makefile | 5 -
> sysdeps/sparc/sparc64/hp-timing.c | 23 ----
> sysdeps/sparc/sparc64/hp-timing.h | 51 +--------
> sysdeps/x86_64/Makefile | 2 -
> sysdeps/x86_64/hp-timing.c | 2 -
> sysdeps/x86_64/hp-timing.h | 23 ++--
> 28 files changed, 102 insertions(+), 882 deletions(-)
> rename sysdeps/{i386/i686/hp-timing.c => aarch64/hp-timing.h} (55%)
> create mode 100644 sysdeps/generic/hp-timing-common.h
> delete mode 100644 sysdeps/ia64/hp-timing.c
> delete mode 100644 sysdeps/powerpc/powerpc32/hp-timing.h
> delete mode 100644 sysdeps/powerpc/powerpc32/power4/hp-timing.c
> delete mode 100644 sysdeps/powerpc/powerpc64/hp-timing.c
> delete mode 100644 sysdeps/sparc/sparc32/sparcv9/hp-timing.c
> delete mode 100644 sysdeps/sparc/sparc64/hp-timing.c
> delete mode 100644 sysdeps/x86_64/hp-timing.c
>
> --
> 1.9.3
--
Will Newton
Toolchain Working Group, Linaro