This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Remove __ASSUME_O_CLOEXEC / O_CLOEXEC conditionals in sysdeps/unix/sysv/linux/

On Wed, 25 Jun 2014, Andreas Schwab wrote:

> "Joseph S. Myers" <> writes:
> > diff --git a/sysdeps/unix/sysv/linux/dl-opendir.c b/sysdeps/unix/sysv/linux/dl-opendir.c
> > index 72d2c06..c1cdc05 100644
> > --- a/sysdeps/unix/sysv/linux/dl-opendir.c
> > +++ b/sysdeps/unix/sysv/linux/dl-opendir.c
> > @@ -1,6 +1 @@
> > -/* In this implementation we do not really care whether the opened
> > -   file descriptor has the CLOEXEC bit set.  The only call happens
> > -   long before there is a call to fork or exec.  */
> > -#undef __ASSUME_O_CLOEXEC
> > -#define __ASSUME_O_CLOEXEC 1
> >  #include <opendir.c>
> That file is no longer needed.

Followup cleanups in that regard for both this and the __ASSUME_ATFCTS 
patch are welcome.  This patch is deliberately conservative to make sure 
that it doesn't change the disassembly of installed shared libraries at 
all (not even e.g. through reordering of the objects linked into them).

Comments are also welcome on the question of whether - again as a followup 
- we should make O_CLOEXEC a required feature for glibc and so remove all 
conditionals on __ASSUME_O_CLOEXEC throughout the source tree.

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]