This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add generic HAVE_RM_CTX implementation

On 17 June 2014 14:14, Will Newton <> wrote:
> On 10 June 2014 17:26, Wilco <> wrote:
>> Marcus wrote:
>>> On 10 June 2014 14:37, Wilco Dijkstra <> wrote:
>>> > Marcus,
>>> >
>>> > Can you check this in?
>>> >
>>> > Wilco
>>> >
>>> > ChangeLog:
>>> > 2014-06-10  Wilco  <>
>>> >
>>> >         * sysdeps/generic/math_private.h: Add default HAVE_RM_CTX
>>> >         implementation. New function (libc_feholdsetround_noex_ctx).
>>> Have all of Joseph's comments been addressed?  I don't see an OK in
>>> the thread....
>> There was an OK in the mail I sent out. The rest of the thread was
>> unrelated to this particular patch.
> It looks like this patch has had OKs from Siddesh and Joseph and a
> tacit OK from Marcus. It tested with no regressions on x86_64, arm and
> aarch64, and looks OK to me too but I don't feel particularly
> qualified in this area.
> Does anybody have any objections to it being applied? If not then I
> can go ahead and apply it if there are no further comments within the
> next 48 hours.

I was about to apply this patch but I realised the version I had
reviewed was the first version of the patch. The second version of the
patch has an #ifndef HAVE_RM_CTX in it which as far as I can tell is a
frowned upon way of handling such architecture defined conditionals.
Joseph, are you happy with the patch as is?


Will Newton
Toolchain Working Group, Linaro

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]