This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/25] Remove nested functions: crypt/md5-crypt.c
- From: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 2 Jun 2014 08:50:51 +0400
- Subject: Re: [PATCH 1/25] Remove nested functions: crypt/md5-crypt.c
- Authentication-results: sourceware.org; auth=none
- References: <CAGQ9bdzqT1EyXYMwACrHpPU=vPjM_b72LJRjb7BW_OzJRXG3bw at mail dot gmail dot com> <20140520131314 dot GB14500 at spoyarek dot pnq dot redhat dot com> <CAGQ9bdw=-pzbi00gn5t_W8pXBjU0edFvLGMNUc+o=g9og=f9+Q at mail dot gmail dot com> <20140522145906 dot GX14500 at spoyarek dot pnq dot redhat dot com> <CAGQ9bdzL=EXg0RrJ6xs5n7uW6xWj6Mgrc5e=WWZ25-07k8ThGQ at mail dot gmail dot com>
Any comment on this patch?
On Thu, May 22, 2014 at 7:14 PM, Konstantin Serebryany
<konstantin.s.serebryany@gmail.com> wrote:
> On Thu, May 22, 2014 at 6:59 PM, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
>> On Tue, May 20, 2014 at 06:23:40PM +0400, Konstantin Serebryany wrote:
>>> 2014-05-20 Kostya Serebryany <konstantin.s.serebryany@gmail.com>
>>>
>>> * crypt/md5-crypt.c (__md5_crypt_r): Remove a nested function.
>>> (b64_from_24bit): New function.
>>>
>>
>> I have pushed this (and the formatting fix) now.
>
> Excellent, thanks!
> Here is the next patch with (hopefully) correct tabs:
>
> 2014-05-22 Kostya Serebryany <konstantin.s.serebryany@gmail.com>
>
> * crypt/crypt-private.h: Include ufc-crypt.h.
> (__b64_from_24bit): Declare extern.
> * crypt/crypt_util.c(__b64_from_24bit): New function.
> (b64t): New static const variable.
> * crypt/md5-crypt.c (b64_from_24bit): Remove function.
> (b64t): Remove variable.
> (__md5_crypt_r): Replace b64_from_24bit with __b64_from_24bit.
> * crypt/sha256-crypt.c: Include crypt-private.h.
> (b64t): Remove variable.
> (__sha256_crypt_r): Remove b64_from_24bit and replace
> with __b64_from_24bit.
> * crypt/sha512-crypt.c: Likewise.
>
>
>
>
>
>
>
>>
>> Siddhesh