This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH roland/nptl-sh] SH: Consolidate NPTL/non versions of vfork
- From: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- To: roland at hack dot frob dot com
- Cc: libc-alpha at sourceware dot org
- Date: Sat, 31 May 2014 11:03:53 +0900 (JST)
- Subject: Re: [PATCH roland/nptl-sh] SH: Consolidate NPTL/non versions of vfork
- Authentication-results: sourceware.org; auth=none
- References: <20140529230926 dot 133C22C3C21 at topped-with-meat dot com> <20140530 dot 134750 dot 439128275 dot kkojima at rr dot iij4u dot or dot jp> <20140530161958 dot 15CE72C39B6 at topped-with-meat dot com>
Roland McGrath <roland@hack.frob.com> wrote:
> I've made that fix on the branch. Please let me know if it works now.
> (Or feel free to just commit it yourself if you prefer.)
I've got
/tmp/ccAPJUC8.s: Assembler messages:
/tmp/ccAPJUC8.s: Error: .size expression for __vfork does not evaluate to a constant
when compiling. From alpha/vfork.S, the patch below may fix
the issue. With it in origin/roland/nptl-sh branch, it looks
vfork objects are in good shape.
Regards,
kaz
--
diff --git a/sysdeps/unix/sysv/linux/sh/vfork.S b/sysdeps/unix/sysv/linux/sh/vfork.S
index 157a38c..76326f5 100644
--- a/sysdeps/unix/sysv/linux/sh/vfork.S
+++ b/sysdeps/unix/sysv/linux/sh/vfork.S
@@ -64,10 +64,7 @@ ENTRY (__libc_vfork)
.L2:
.word PID - TLS_PRE_TCB_SIZE
.align 2
-PSEUDO_END (__vfork)
-libc_hidden_def (__vfork)
-
-weak_alias (__vfork, vfork)
+PSEUDO_END (__libc_vfork)
#if !NOT_IN_libc
weak_alias (__libc_vfork, vfork)