This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
RE: [PATCH] ARM - Rewrite feupdateenv
- From: "Wilco" <wdijkstr at arm dot com>
- To: "'Joseph Myers'" <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 28 May 2014 14:10:31 +0100
- Subject: RE: [PATCH] ARM - Rewrite feupdateenv
- Authentication-results: sourceware.org; auth=none
- References: <000901cf7698$bf4a2e10$3dde8a30$ at com> <Pine dot LNX dot 4 dot 64 dot 1405231517080 dot 17788 at digraph dot polyomino dot org dot uk>
> From: Joseph Myers wrote:
> On Fri, 23 May 2014, Wilco wrote:
>
> > This patch rewrites feupdateenv to improve performance by avoiding
> > unnecessary FPSCR reads/writes and to fix bug 16918
> > (https://sourceware.org/bugzilla/show_bug.cgi?id=16918).
>
> It would be desirable to add an architecture-independent testcase that, if
> FE_NOMASK_ENV is defined and feupdateenv (FE_NOMASK_ENV) succeeds, the
> exceptions are then enabled as indicated by fegetexcept (or by getting
> SIGFPE, as test-fenv.c tests various cases, but a test using fegetexcept
> is simpler to write). (It's best for this to be a new test rather than
> adding to the things in test-fenv.c.)
I'll add such a test in a separate patch (as a separate test it's best to
test all of fesetenv, feupdateenv and feenableexcept so we've covered all
of the special cases in one go).
Wilco