This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 5/5] PowerPC: Move remaining, nptl/sysdeps/unix/sysv/linux/powerpc/ files.
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Fri, 23 May 2014 15:06:15 -0700 (PDT)
- Subject: Re: [PATCH 5/5] PowerPC: Move remaining, nptl/sysdeps/unix/sysv/linux/powerpc/ files.
- Authentication-results: sourceware.org; auth=none
- References: <537F4CC7 dot 6040202 at linux dot vnet dot ibm dot com>
When you are posting a change that is largely verbatim file moves, and
especially if you aren't expecting people to apply the patch themselves
with 'patch' (because you supplied a git branch, or because you advise
people they'll have to use 'git apply'), using 'git diff --renames' makes
the diff a lot easier to review.
> * nptl/sysdeps/unix/sysv/linux/powerpc/Makefile: Moved ...
> * sysdeps/unix/sysv/linux/powerpc/nptl/Makefile: ... here.
Not helpful. At the end of the day, there should not be a
sysdeps/unix/sysv/linux/powerpc/nptl/ subdirectory at all. You need to
merge the nptl/.../Makefile contents into the existing
sysdeps/unix/sysv/linux/powerpc/Makefile instead. Note that they
really should have an 'ifeq ($(subdir),nptl)' conditional that the
old Makefile was missing.
The rest looks fine off hand.
Thanks,
Roland