This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove second argument from TLS_INIT_TP macro
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: libc-alpha at sourceware dot org, Thomas Schwinge <tschwinge at gnu dot org>
- Date: Wed, 14 May 2014 09:25:05 -0700 (PDT)
- Subject: Re: [PATCH] Remove second argument from TLS_INIT_TP macro
- Authentication-results: sourceware.org; auth=none
- References: <mvmbnv1veku dot fsf at hawking dot suse dot de> <20140513170157 dot CB9D82C3A1B at topped-with-meat dot com> <mvm1tvwvn15 dot fsf at hawking dot suse dot de>
> Roland McGrath <roland@hack.frob.com> writes:
>
> >> --- a/nptl/sysdeps/i386/tls.h
> >> +++ b/nptl/sysdeps/i386/tls.h
> >> @@ -195,7 +195,7 @@ union user_desc_init
> >> /* Code to initially initialize the thread pointer. This might need
> >> special attention since 'errno' is not yet available and if the
> >> operation can cause a failure 'errno' must not be touched. */
> >> -# define TLS_INIT_TP(thrdescr, secondcall) \
> >> +# define TLS_INIT_TP(thrdescr) \
> >> ({ void *_thrdescr = (thrdescr); \
> >> tcbhead_t *_head = _thrdescr; \
> >> union user_desc_init _segdescr; \
> >> @@ -208,10 +208,7 @@ union user_desc_init
> >> INIT_SYSINFO; \
> >> \
> >> /* The 'entry_number' field. Let the kernel pick a value. */ \
> >> - if (secondcall) \
> >> - _segdescr.vals[0] = TLS_GET_GS () >> 3; \
> >> - else \
> >> - _segdescr.vals[0] = -1; \
> >> + _segdescr.vals[0] = -1; \
> >
> > Please leave a comment behind explaining what -1 means here.
>
> ??? I didn't remove the comment.
OK.