This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Fix HP_SMALL_TIMING_AVAIL undef warnings

On Mon, 2014-04-28 at 14:53 +0000, Joseph S. Myers wrote:
> On Mon, 28 Apr 2014, Will Newton wrote:
> > This looks like it is the right thing to do, however I believe the
> > warnings will persist on:
> > 
> > ia64
> > x86_64
> > i386
> > powerpc32
> > powerpc64
> > sparc32
> > sparc64
> > 
> > Which all use their own hp-timing.h.
> Indeed.  For such a patch you need to:

It seems a bit ugly to have to define 
HP_SMALL_TIMING_AVAIL as 0 in 8 different hp-timing.h header files.
Would the idea of each of these hp-timing.h header files including the
default hp-timing.h header file and then only overriding the macros they
need to redefine be considered acceptable?  I see a few uses of
"#include_next" in glibc but not in any header files where a platform is
redefining a generic header.  Those all seem to be complete
replacements.  How about a new header file of default macro definitions
(not necessarily just the timing macros)?  Is that something that could
be considered to provide default values for macros?  Or has that idea
already been dismissed?

Steve Ellcey

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]