This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH 2/N, MPX, x86_64] Intel MPX support in glibc for x86_64
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, "Zamyatin, Igor" <igor dot zamyatin at intel dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, OndÅej BÃlka <neleai at seznam dot cz>
- Date: Fri, 25 Apr 2014 14:41:12 -0400
- Subject: Re: [PATCH 2/N, MPX, x86_64] Intel MPX support in glibc for x86_64
- Authentication-results: sourceware.org; auth=none
- References: <0EFAB2BDD0F67E4FB6CCC8B9F87D756942973E8E at IRSMSX101 dot ger dot corp dot intel dot com> <5359FBA4 dot 7010203 at redhat dot com> <Pine dot LNX dot 4 dot 64 dot 1404251425350 dot 16509 at digraph dot polyomino dot org dot uk> <535A8A8F dot 5080807 at redhat dot com> <CAMe9rOo9__Kzh4EZipsnNmMRzWVm1NcKLWFeF3rALsWyKpaHUQ at mail dot gmail dot com>
On 04/25/2014 12:38 PM, H.J. Lu wrote:
> On Fri, Apr 25, 2014 at 9:17 AM, Carlos O'Donell <email@example.com> wrote:
>> On 04/25/2014 10:30 AM, Joseph S. Myers wrote:
>>> On Fri, 25 Apr 2014, Carlos O'Donell wrote:
>>>> You should test for __int128, set HAVE_INT128, and make this
>>>> support conditional on the compiler feature being present
>>>> (avoid hard-coding the compiler version). I believe Ondrej
>>>> posted a patch for this?
>>> bits/link.h is an installed header so can't contain conditionals on
>>> configure test results like that.
>>> However, the __int128_t built-in typedef is much older than the __int128
>>> keyword (dating back to GCC 3.0, i.e. predating x86_64 support which was
>>> added in 3.1), so that can be used instead.
>> Agreed. Thanks for catching the fact that this is an installed header.
> I tested and checked in this patch to replace __int128 with __int128_t.
Awesome. Thanks for the quick turnaround HJ.
The fact that this is an installed header makes it even more important
that we reduce the compiler requirement for usage.