This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Multiarch optimization for strspn on POWERPC
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Sat, 29 Mar 2014 18:01:52 +0100
- Subject: Re: [PATCH] Multiarch optimization for strspn on POWERPC
- Authentication-results: sourceware.org; auth=none
- References: <5315CD58 dot 5080002 at linux dot vnet dot ibm dot com> <53163BD1 dot 5000106 at linux dot vnet dot ibm dot com> <53199E07 dot 6040009 at linux dot vnet dot ibm dot com> <531DCEA2 dot 4060305 at linux dot vnet dot ibm dot com> <531DF824 dot 3040302 at linux dot vnet dot ibm dot com> <531F1C0C dot 3030509 at linux dot vnet dot ibm dot com> <532050ED dot 1040402 at linux dot vnet dot ibm dot com>
Adhemerval Zanella <azanella@linux.vnet.ibm.com> writes:
> I also commit the obvious fix that I didn't see previously:
>
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/strspn.c b/sysdeps/powerpc/powerpc64/multiarch/strspn.c
> index 44945f3..bf8c877 100644
> --- a/sysdeps/powerpc/powerpc64/multiarch/strspn.c
> +++ b/sysdeps/powerpc/powerpc64/multiarch/strspn.c
> @@ -16,7 +16,7 @@
> License along with the GNU C Library; if not, see
> <http://www.gnu.org/licenses/>. */
>
> -#if defined SHARED && !defined NOT_IN_libc
> +#ifndef NOT_IN_libc
> # include <string.h>
> # include <shlib-compat.h>
> # include "init-arch.h"
The static libc generally should only contain the generic version.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."