This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Finish __builtin_expect -> __glibc_{un}likely cleanup in elf/dl-load.c
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 27 Mar 2014 18:31:41 +0100
- Subject: Re: [patch] Finish __builtin_expect -> __glibc_{un}likely cleanup in elf/dl-load.c
- Authentication-results: sourceware.org; auth=none
- References: <ye6qeh1o7ab8 dot fsf at elbrus2 dot mtv dot corp dot google dot com> <20140327114201 dot GA32440 at domone dot podge> <CALoOobOc83sR_NWwh4TFqh1ewTuGeP-F_3-nawgffMnGGVFg5A at mail dot gmail dot com>
On Thu, Mar 27, 2014 at 09:42:54AM -0700, Paul Pluzhnikov wrote:
>
> >> @@ -2230,7 +2228,7 @@ _dl_map_object (struct link_map *loader, const char *name,
> >>
> >> #ifdef USE_LDCONFIG
> >> if (fd == -1
> >> - && (__builtin_expect (! (mode & __RTLD_SECURE), 1)
> >> + && (__glibc_likely ((mode & __RTLD_SECURE) == 0)
> >> || ! INTUSE(__libc_enable_secure))
> >> && __glibc_likely (GLRO(dl_inhibit_cache) == 0))
> >> {
> >
> > Extra parens here.
>
> Are there? I don't see them :-(
>
Never mind, when I saw that I forgotten that & has weird precedence.