This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH roland/Versions.def] Get rid of Versions.def source file
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Tue, 25 Mar 2014 17:54:59 -0400
- Subject: Re: [PATCH roland/Versions.def] Get rid of Versions.def source file
- Authentication-results: sourceware.org; auth=none
- References: <20140228214559 dot BD8BF744B6 at topped-with-meat dot com> <Pine dot LNX dot 4 dot 64 dot 1403211805400 dot 4557 at digraph dot polyomino dot org dot uk> <20140321201830 dot 3221874477 at topped-with-meat dot com> <Pine dot LNX dot 4 dot 64 dot 1403212238150 dot 19717 at digraph dot polyomino dot org dot uk> <20140321225348 dot 142A8744AA at topped-with-meat dot com>
On 03/21/2014 06:53 PM, Roland McGrath wrote:
>> No, it worked previously - the point is that GLIBC_2.2.5 is only mentioned
>> in Versions files (sysdeps/unix/bsd/Versions
>> sysdeps/unix/sysv/linux/x86_64/Versions mach/Versions hurd/Versions) that
>> aren't used for MIPS, but used in SHLIB_COMPAT in files that are used for
>> MIPS.
>
> Oh, I see. Before Versions.def had the union of all sysdeps/.../Versions
> files in the source tree. Now the generated file gets only the union of
> all Versions files actually selected in the current configuration. Someone
> (like Carlos when reviewing my change ;->) should check what Versions.def
> items were lost in some configuration. But I guess the ones that matter
> will come out in usual testing now with -Wundef.
For the record I only tested on x86*, and not on other targets.
This particular breakage did not occur to me, and I didn't
notice it in my review. I had also forgotten that we had GCC_*
versions in glibc as part of our ABI compatibility as the
implementation. That certainly complicates assembling a Version.def
file automatically.
Cheers,
Carlos.