This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC: Define __PTHREAD_MUTEX_HAVE_ELISION to 0
- From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 25 Mar 2014 13:03:11 -0300
- Subject: Re: [PATCH] PowerPC: Define __PTHREAD_MUTEX_HAVE_ELISION to 0
- Authentication-results: sourceware.org; auth=none
- References: <532C872D dot 8030107 at linux dot vnet dot ibm dot com> <53318BC9 dot 40404 at linux dot vnet dot ibm dot com> <mvmwqfil26w dot fsf at hawking dot suse dot de>
On 25-03-2014 12:37, Andreas Schwab wrote:
> Adhemerval Zanella <azanella@linux.vnet.ibm.com> writes:
>
>> On 21-03-2014 15:38, Adhemerval Zanella wrote:
>>> This patch cleanups the compiler warnings on powerpc* builds.
>>>
>>> --
>>>
>>> * nptl/sysdeps/unix/sysv/linux/powerpc/bits/pthreadtypes.h
>>> (__PTHREAD_MUTEX_HAVE_ELISION): Define it to 0.
>>>
>>> ---
>>>
>>> diff --git a/nptl/sysdeps/unix/sysv/linux/powerpc/bits/pthreadtypes.h b/nptl/sysdeps/unix/sysv/linux/powerpc/bits/pthreadtypes.h
>>> index 71bd3ae..ac7351f 100644
>>> --- a/nptl/sysdeps/unix/sysv/linux/powerpc/bits/pthreadtypes.h
>>> +++ b/nptl/sysdeps/unix/sysv/linux/powerpc/bits/pthreadtypes.h
>>> @@ -21,6 +21,8 @@
>>>
>>> #include <bits/wordsize.h>
>>>
>>> +#define __PTHREAD_MUTEX_HAVE_ELISION 0
>>> +
>>> #if __WORDSIZE == 64
>>> # define __SIZEOF_PTHREAD_ATTR_T 56
>>> # define __SIZEOF_PTHREAD_MUTEX_T 40
>>>
>> Pushed upstream as 449282f2e0e850c29f6a9666058503d4734964f0
> That should be made archtecture independent, since it is an
> x86/s390-only macro. It doesn't make sence to force everyone to define
> it.
>
> Andreas.
>
I agree with you, but the patch to check if it is defined in nptl/sysdeps/pthread/pthread.h
was rejected: https://sourceware.org/ml/libc-alpha/2014-03/msg00494.html. So I just folowed
the way x86_64 and s390 does. If this was just an warning I'd rework it to make it more general,
as Roland as suggested in https://sourceware.org/ml/libc-alpha/2014-03/msg00501.html; but it is
breaking 'make check' build. So my preference now is let it as and focus on a proper fix, if
any, after.