This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/4] Detailed benchmark outputs for functions
- From: Will Newton <will dot newton at linaro dot org>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Tue, 25 Mar 2014 12:29:05 +0000
- Subject: Re: [PATCH 2/4] Detailed benchmark outputs for functions
- Authentication-results: sourceware.org; auth=none
- References: <20140325102941 dot GB1850 at spoyarek dot pnq dot redhat dot com>
On 25 March 2014 10:29, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> Hi,
>
> This patch adds an option to get detailed benchmark output for
> functions. Invoking the benchmark with 'make DETAILED=1 bench' causes
> each benchmark program to store a mean execution time for each input
> it works on. This is useful to give a more comprehensive picture of
> performance of functions compared to just the single mean figure.
>
> Siddhesh
>
> * benchtests/Makefile (DETAILED_OPT): New make option.
> (bench-func): Run benchmark program with -d if DETAILED_OPT is
> set.
> * benchtests/bench-skeleton.c: Include stdbool.h.
> (main): Store and print timings per input.
> * benchtests/scripts/bench.py (STRUCT_TEMPLATE): Add timing
> member to each argument value.
> (EPILOGUE): Define new macros RESULT and RESULT_ACCUM.
> (_print_arg_data): Initialize per-input timing to 0.
This looks ok to me.
--
Will Newton
Toolchain Working Group, Linaro