This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix BZ #16634 -- assert in ld.so when dlopen("a.out"...) is called repeatedly.

From: Mike Frysinger <vapier at gentoo dot org>
To: libc-alpha at sourceware dot org
Cc: Paul Pluzhnikov <ppluzhnikov at google dot com>, Siddhesh Poyarekar <siddhesh at redhat dot com>
Date: Sat, 22 Mar 2014 00:35:46 -0400
Subject: Re: [patch] Fix BZ #16634 -- assert in ld.so when dlopen("a.out"...) is called repeatedly.
Authentication-results: sourceware.org; auth=none
References: <ye6qpplo78g2 dot fsf at elbrus2 dot mtv dot corp dot google dot com> <20140316105130 dot GJ1850 at spoyarek dot pnq dot redhat dot com> <CALoOobOt4q05ht82tWw3P=+TgR5sp3HW=DFpJC57O9knXzO6iQ at mail dot gmail dot com>

On Fri 21 Mar 2014 15:39:13 Paul Pluzhnikov wrote:
> On Sun, Mar 16, 2014 at 3:51 AM, Siddhesh Poyarekar wrote:
> > On Fri, Mar 14, 2014 at 02:54:05PM -0700, Paul Pluzhnikov wrote:
> >> Attached patch fixes BZ #16634 by moving sanity check for dlopen()ing
> >> a.out before we call _dl_next_tls_modid() for it.
> >> 
> >> Tested on Linux/x86_64; no new failures.
> > 
> > A more detailed description please, assuming that it's going to be
> > used for the commit log.
> 
> I usually just use ChangeLog as commit log.
> Should I be using more verbose patch description instead?

yes, your commit log needs to be useful by itself.  see 
b36208627c3cd3b5f031a4e42d0f21211f7ccba0 as an example.  whether the ChangeLog 
is posted inline is up to the respective committer at this time.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

References:
- [patch] Fix BZ #16634 -- assert in ld.so when dlopen("a.out"...) is called repeatedly.
  - From: Paul Pluzhnikov
- Re: [patch] Fix BZ #16634 -- assert in ld.so when dlopen("a.out"...) is called repeatedly.
  - From: Siddhesh Poyarekar
- Re: [patch] Fix BZ #16634 -- assert in ld.so when dlopen("a.out"...) is called repeatedly.
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]