This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH roland/mman-linux] Move bits/mman-linux.h out of sysdeps/unix/sysv/linux/.
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Tue, 18 Mar 2014 14:52:06 -0700 (PDT)
- Subject: Re: [PATCH roland/mman-linux] Move bits/mman-linux.h out of sysdeps/unix/sysv/linux/.
- Authentication-results: sourceware.org; auth=none
- References: <20140314200309 dot 83A247449E at topped-with-meat dot com> <5323754A dot 3020505 at redhat dot com>
> I'm happy with such a change. A perfectly structured set of headers is the
> enemy of the good. I think reducing duplication of these constants is a good
> thing.
I merged it.
> Every other way I can think of organizing the header, include_next, or
> something else, just looks uglier than moving the header. So your solution
> seems like the most reasonable.
I also had a hack where sysdeps/.../Makefile just copied the source file to
the build directory. That works well enough and avoids nastiness inside
the file itself. But it's less clean than moving the file.
> On request. Add enough comments that we know why this file is there so
> someone reading either Makefile's or the header itself knows why it's
> not where it should be.
I forgot about this request before I pushed the change.
I'll add some comments now.
Thanks,
Roland