This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] S/390:
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 18 Mar 2014 14:11:05 +0000
- Subject: Re: [PATCH] S/390:
- Authentication-results: sourceware.org; auth=none
- References: <lfuu4e$uam$3 at ger dot gmane dot org> <Pine dot LNX dot 4 dot 64 dot 1403141415341 dot 17775 at digraph dot polyomino dot org dot uk> <lg9f99$e01$1 at ger dot gmane dot org>
On Tue, 18 Mar 2014, Stefan Liebler wrote:
> I fixed the header as mentioned. The tests pass on s390/s390x.
> Unifying s390/s390-32/bits/wordsize.h and s390/s390-64/wordsize.h to
> s390/bits/wordsize.h leads to a build error:
I suppose there must be some non-obvious sysdeps directory ordering issue,
so another bits/wordsize.h gets found if you unify those headers?
> 2014-03-18 Stefan Liebler <stli@linux.vnet.ibm.com>
>
> [BZ #16712]
> * sysdeps/s390/s390-32/bits/wordsize.h
> (__WORDSIZE32_SIZE_ULONG): New define.
> * sysdeps/s390/s390-64/bits/wordsize.h
> (__WORDSIZE32_SIZE_ULONG): Likewise.
> * sysdeps/generic/stdint.h (SIZE_MAX):
> Define as UL if __WORDSIZE32_SIZE_ULONG.
OK.
I believe there's a previous approval of mine for (part of) a patch of
yours <https://sourceware.org/ml/libc-alpha/2014-02/msg00819.html> that
hasn't been committed.
--
Joseph S. Myers
joseph@codesourcery.com