This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PLEASE FIX NOW! make check-abi exits zero on failure
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Mon, 17 Mar 2014 17:59:01 -0700 (PDT)
- Subject: Re: PLEASE FIX NOW! make check-abi exits zero on failure
- Authentication-results: sourceware.org; auth=none
- References: <20140317225024 dot 5DDBC74464 at topped-with-meat dot com> <Pine dot LNX dot 4 dot 64 dot 1403180005590 dot 3606 at digraph dot polyomino dot org dot uk>
> Since you want a quick fix, I've applied this patch. (Really the
> subdirectory check-abi targets should generate .sum files and then
> toplevel combine those, just like the tests and xtests targets.)
That suffices for the moment, yes. I am all for cleanups in the
organization of testing targets and appreciative of work toward that,
though I have not at all followed the details of what you and others have
been doing in that regard. But I am wholly intolerant of regressions in
the top-level behavior or common developer practices (including things like
'make check subdirs=foo'). Please take care to avoid introducing more, and
double-check for any more like this that you may have introduced. If you
change any such behavior intentionally and think that the change is
preferable, please be sure to make clear announcements about what you
propose in obvious RFC or PSA messages that are concise and not just
mention it buried in verbiage about some particular change's review or
other such things that are easily missed by those of us not reading every
word of every post.
Thanks,
Roland