This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Provide correct buffer length to netgroup queries in nscd (BZ #16695)
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 12 Mar 2014 10:53:08 +0100
- Subject: Re: [PATCH] Provide correct buffer length to netgroup queries in nscd (BZ #16695)
- Authentication-results: sourceware.org; auth=none
- References: <20140312090859 dot GA887 at spoyarek dot pnq dot redhat dot com>
On Wed, Mar 12, 2014 at 02:38:59PM +0530, Siddhesh Poyarekar wrote:
> The buffer to query netgroup entries is allocated sufficient space for
> the netgroup entries and the key to be appended at the end, but it
> sends in an incorrect available length to the NSS netgroup query
> functions, resulting in overflow of the buffer in some special cases.
> The fix here is to factor in the key length when sending the available
> buffer and buffer length to the query functions.
>
> Tested on x86_64. OK to commit?
>
Looks ok.