This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [WIP PATCH] Add int128 detection
- From: Roland McGrath <roland at hack dot frob dot com>
- To: OndÅej BÃlka <neleai at seznam dot cz>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 11 Mar 2014 11:20:42 -0700 (PDT)
- Subject: Re: [WIP PATCH] Add int128 detection
- Authentication-results: sourceware.org; auth=none
- References: <20140221143228 dot GA11081 at domone dot podge> <20140221175706 dot DB67E7449E at topped-with-meat dot com> <20140224150122 dot GA6178 at domone dot podge>
> +AC_CACHE_CHECK(if compiler supports __int128,libc_cv_have_int128,[dnl,
Spaces after the commas. No comma after dnl.
> + AC_TRY_COMPILE([#include <stdint.h>],
> + [ __int128 a = 0;
> + unsigned __int128 b = 1;
Drop the excess leading space after [ there and adjust following
indentation accordingly.
> + return 0;], libc_cv_have_int128=yes, libc_cv_have_int128=no)])
Break this line after the first comma so it's not too long.
With those nits, this configure change is OK. But it should not go in
until there is something that actually uses it.