This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #16046] Static dlopen correction fallout fixes
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: Ondřej Bílka <neleai at seznam dot cz>, Allan McRae <allan at archlinux dot org>, <libc-alpha at sourceware dot org>
- Date: Wed, 29 Jan 2014 10:49:54 -0800 (PST)
- Subject: Re: [PATCH][BZ #16046] Static dlopen correction fallout fixes
- Authentication-results: sourceware.org; auth=none
- References: <20131017174710 dot GA4993 at domone dot podge> <20131025210328 dot 39E69746B6 at topped-with-meat dot com> <alpine dot DEB dot 1 dot 10 dot 1310252347350 dot 12843 at tp dot orcam dot me dot uk> <20140116203847 dot GB20838 at domone dot podge> <alpine dot DEB dot 1 dot 10 dot 1401172303320 dot 4268 at tp dot orcam dot me dot uk> <20140117233957 dot 64E307441B at topped-with-meat dot com> <alpine dot DEB dot 1 dot 10 dot 1401271320170 dot 4268 at tp dot orcam dot me dot uk> <alpine dot DEB dot 1 dot 10 dot 1401291054290 dot 4268 at tp dot orcam dot me dot uk>
The changes look fine to me. Allan has the say on whether they are safe
enough for 2.19, but I think that the fact that only static binaries should
be affected should lower the bar here. That case would be helped if you
could verify that your patch results in no code changes to ld.so or libc.so
(i.e. compare objdump -rd on old vs new).
I'm not sure off hand how best to construct a good test case.
But I think that we should not call the subject closed until
we have an effective regression test in the suite.
Thanks,
Roland