This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
| Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
|---|---|---|
| Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
| Other format: | [Raw text] | |
On 3/01/2014, at 9:17 am, OndÅej BÃlka <neleai@seznam.cz> wrote: > On Mon, Dec 23, 2013 at 01:26:20PM +0400, Yuriy Kaminskiy wrote: ... >> --- glibc/sysdeps/i386/i686/memmove.S.orig >> +++ glibc/sysdeps/i386/i686/memmove.S >> @@ -63,8 +63,8 @@ >> >> movl %edi, %eax >> subl %esi, %eax >> - cmpl %eax, %edi >> - jae 3f >> + cmpl %eax, %ecx >> + ja 3f >> >> cld >> shrl $1, %ecx > > Looks good. As bugfix it needs a bugzilla entry and update > changelog/news. Maxim could you do that? I've created BZ #16394. The attached patch was tested in i686 environment with memmove ifunc forced to resolve to implementation in sysdeps/i386/i686/memmove.S. I will check in the patch in 24 hours since at least 3 developers have looked at it and confirmed that it is the right fix. Thanks, -- Maxim Kuvyrkov www.kugelworks.com
Attachment:
0001-Fix-a-thinko-typo-in-i686-s-memmove-aka-__memmove_ia.patch
Description: Binary data
| Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
|---|---|---|
| Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |