This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/committed] tst-fanotify: check for linux/fanotify.h existence


On Tue, 31 Dec 2013, Mike Frysinger wrote:

> +# Until we start requiring 2.6.37+ headers, we need to check for the
> +# availability of linux/fanotify.h for testing purposes.
> +AC_CHECK_HEADER(linux/fanotify.h,
> +  [DEFINES="$DEFINES -DHAVE_LINUX_FANOTIFY_H=1"], ,
> +  [/* No default includes.  */])

Why are you using DEFINES instead of the normal approach of AC_DEFINE?  
We know it's not ideal for the toplevel config.h.in to contain 
system-specific defines - see bug 14068 - but I don't think using DEFINES 
is a good workaround; it's better to keep all such cases using the same 
mechanism so it's easier to find them to make them use a newer cleaner 
mechanism.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]