This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH 2/4] Add a signal-safe malloc replacement
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: Paul Pluzhnikov <ppluzhnikov at google dot com>, Andrew Hunter <ahh at google dot com>, GNU C Library <libc-alpha at sourceware dot org>, Carlos O'Donell <carlos at redhat dot com>
- Date: Thu, 19 Dec 2013 19:07:18 +0100
- Subject: Re: [PATCH 2/4] Add a signal-safe malloc replacement
- Authentication-results: sourceware.org; auth=none
- References: <1386722143-10513-1-git-send-email-ahh at google dot com> <1386722143-10513-2-git-send-email-ahh at google dot com> <20131211100309 dot GA24512 at domone dot podge> <CALoOobMKYyD7G7fbYHq2aqx32S_QMs19DZY2YhJ-JA4_d4717A at mail dot gmail dot com> <CADroS=7LJ4uKGB30jsNn2xV5Dxr7eZ24H3NScHUCYWORUnMTfQ at mail dot gmail dot com> <CALoOobP0xGCB_6Vf9uTizqctJP1r9aW2eRoBFNeaHHASWd75mg at mail dot gmail dot com> <CALoOobOT_os7AuCB+_+fy+u9LOaRajBLoQKgf20vKeqYTxRJhg at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1312191656360 dot 8877 at digraph dot polyomino dot org dot uk> <20131219174011 dot GA24862 at domone dot podge> <Pine dot LNX dot 4 dot 64 dot 1312191744260 dot 8877 at digraph dot polyomino dot org dot uk>
On Thu, Dec 19, 2013 at 05:48:08PM +0000, Joseph S. Myers wrote:
> On Thu, 19 Dec 2013, Ondrej Bilka wrote:
> > One possible approach would be have a warning subsection in Makefile like:
> > # gcc gets false positive on line 42
> > CFLAGS-foo.c += -Wno-error=bar
> If we do this, I think we should actually quote something of the warning
> rather than just giving a line number that may be meaningless after source
> code changes.
only a example.
> There are quite a lot of -Wno- options in various Makefiles in the source
> tree. It would be good to review them and see if some are in fact no
> longer needed, or if the relevant code can be fixed to avoid them.
> Generally any such workarounds for warnings need occasional review to
> avoid them staying around longer than necessary and so meaning warnings
> pointing out real problems get missed.
When these are moved in one place then they could be surrounded by for example
then one could check what needs to be fixed.