This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/4] Add a signal-safe malloc replacement

On Thu, Dec 19, 2013 at 05:48:08PM +0000, Joseph S. Myers wrote:
> On Thu, 19 Dec 2013, Ondrej Bilka wrote:
> > One possible approach would be have a warning subsection in Makefile like:
> > 
> > # gcc gets false positive on line 42
> > CFLAGS-foo.c += -Wno-error=bar
> If we do this, I think we should actually quote something of the warning 
> rather than just giving a line number that may be meaningless after source 
> code changes.
only a example. 
> There are quite a lot of -Wno- options in various Makefiles in the source 
> tree.  It would be good to review them and see if some are in fact no 
> longer needed, or if the relevant code can be fixed to avoid them.  
> Generally any such workarounds for warnings need occasional review to 
> avoid them staying around longer than necessary and so meaning warnings 
> pointing out real problems get missed.
When these are moved in one place then they could be surrounded by for example

ifndef show_all_errors

then one could check what needs to be fixed.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]