This is the mail archive of the
mailing list for the glibc project.
Re: [PING][PATCH][BZ #926] Mention timezone for strftime %s
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: libc-alpha at sourceware dot org, Paul Eggert <eggert at cs dot ucla dot edu>
- Date: Wed, 4 Dec 2013 13:28:24 +0100
- Subject: Re: [PING][PATCH][BZ #926] Mention timezone for strftime %s
- Authentication-results: sourceware.org; auth=none
- References: <20131012165835 dot GA26247 at domone dot podge> <52714E5C dot 5000006 at cs dot ucla dot edu> <20131105143005 dot GF24734 at domone dot podge> <201311300257 dot 35152 dot vapier at gentoo dot org>
On Sat, Nov 30, 2013 at 02:57:34AM -0500, Mike Frysinger wrote:
> On Tuesday 05 November 2013 09:30:05 OndÅej BÃlka wrote:
> > On Wed, Oct 30, 2013 at 11:22:20AM -0700, Paul Eggert wrote:
> > > On 10/30/2013 08:38 AM, OndÅej BÃlka wrote:
> > > > +Note that like mktime, this uses the current time zone instead of
> > > > tm_gmtoff.
> > >
> > > I like the idea of documenting this part of strftime, but the proposed
> > > documentation could be improved. First, it's not just tm_gmtoff; it's
> > > also tm_zone. Second, the documentation for mktime doesn't mention
> > > the fact that mktime uses the current time zone rather than tm_gmtoff,
> > > and it's odd that one must look to strftime to find this fact
> > > documented. Third, words like mktime and tm_gmtoff should be marked
> > > with @code. Fourth, let's omit the "Note that." And finally, there
> > > are similar problems elsewhere in that chapter.
> > >
> > > How about the following patch instead?
> > Yes, this one is better.
> one of you want to merge it then ? :)
Ok, I merged this with following changelog.
diff --git a/ChangeLog b/ChangeLog
index b49a811..55f2c2d 100644
@@ -1,3 +1,9 @@
+2013-12-04 Paul Eggert <email@example.com>
+ [BZ #926]
+ * manual/time.texi (Calendar Time): Clarify what timezone functions