This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC: Set/restore rounding mode only when needed
- From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Mon, 25 Nov 2013 10:39:38 -0200
- Subject: Re: [PATCH] PowerPC: Set/restore rounding mode only when needed
- Authentication-results: sourceware.org; auth=none
- References: <5280DDA5 dot 1060906 at linux dot vnet dot ibm dot com> <20131119131935 dot GE24544 at spoyarek dot pnq dot redhat dot com> <528CBBE7 dot 8040109 at linux dot vnet dot ibm dot com> <20131125095330 dot GN19834 at spoyarek dot pnq dot redhat dot com>
Hi Siddhesh, thanks again for the review.
On 25-11-2013 07:53, Siddhesh Poyarekar wrote:
>> +static __always_inline void
>> > +libc_fesetround_ppc (int r)
>> > +{
>> > + fesetround (r);
> Shouldn't this be __fesetround? The rest of the patch looks OK to me.
>
> Siddhesh
>
Indeed this is a missing optimization, I have fixed it.
Pushed upstream as 41e8926aa4b7f17bc95984737ee82a254ad0911c.