This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] _dl_tlsdesc_resolve_rela issue.

On Oct 18, 2013, OndÅej BÃlka <> wrote:

> There are two questions that I have to this file. First is why it saves
> r10, r11 but normal trampoline does not save these.

Normal trampolines only have to preserve registers used for argument
passing, while TLS resolvers have to preserve all registers.

> Second is why _dl_tlsdesc_resolve_hold uses
> jmp     *(%eax)

This is a bug, likely the result of a cut&pasto from the i386 version on
which it was initially based.  It should be %rax.  Looks like we haven't
had very many cases of concurrent lazy relocation of the same TLS
descriptor in programs that get libc loaded outside the 32-bit address
range ;-)  Thanks for catching this, and thanks in advance for fixing
it.  The obvious patch is pre-approved.

Alexandre Oliva, freedom fighter
You must be the change you wish to see in the world. -- Gandhi
Be Free! --   FSF Latin America board member
Free Software Evangelist      Red Hat Brazil Compiler Engineer

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]