This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PowerPC64 ELFv2 ABI 5/6: LD_AUDIT interface changes

Hi Uli,

On 12-11-2013 19:23, Ulrich Weigand wrote:
> Hello,
> the ELFv2 ABI changes the calling convention by passing and returning
> structures in registers in more cases than the old ABI:
> For the most part, this does not affect glibc, since glibc assembler
> files do not use structure parameters / return values.  However, one
> place is affected: the LD_AUDIT interface provides a structure to
> the audit routine that contains all registers holding function
> argument and return values for the intercepted PLT call.
> Since the new ABI now sometimes uses registers to return values
> that were never used for this purpose in the old ABI, this structure
> has to be extended.  To force audit routines to be modified for the
> new ABI if necessary, the patch defines v2 variants of the la_ppc64
> types and routines.

This patch is ok, thanks!

> In addition, the patch contains two unrelated changes to the
> PLT trampoline routines: it fixes a bug where FPR return values
> were stored in the wrong place, and it removes the unnecessary
> save/restore of CR.

Is this bug user visible? Do we have a bug report for this?

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]