This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 01/17] PowerPC: change sysdeps fpu folder

From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
To: "Joseph S. Myers" <joseph at codesourcery dot com>
Cc: "GNU C. Library" <libc-alpha at sourceware dot org>, "Steven J. Munroe" <sjmunroe at us dot ibm dot com>
Date: Wed, 20 Nov 2013 11:19:44 -0200
Subject: Re: [PATCH 01/17] PowerPC: change sysdeps fpu folder
Authentication-results: sourceware.org; auth=none
References: <528B815A dot 4030004 at linux dot vnet dot ibm dot com> <528B8FD9 dot 8010505 at linux dot vnet dot ibm dot com> <Pine dot LNX dot 4 dot 64 dot 1311191704330 dot 534 at digraph dot polyomino dot org dot uk>

On 19-11-2013 15:06, Joseph S. Myers wrote:
> On Tue, 19 Nov 2013, Adhemerval Zanella wrote:
>
>> This patch makes the fpu/multiarch folder appears in front of the
>> powerpc/fpu folder.
>>
>> With a POWER4 configured build th sysdeps folder shows this difference:
>>
>> --- sysdeps_before_ppc32
>> +++ sysdeps_after_ppc32
>> @@ -1,6 +1,5 @@
>>  sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/nptl
>>  sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu
>> -sysdeps/powerpc/powerpc32/fpu
>>  nptl/sysdeps/unix/sysv/linux/powerpc/powerpc32
>>  sysdeps/unix/sysv/linux/powerpc/powerpc32
>>  nptl/sysdeps/unix/sysv/linux/powerpc
>> @@ -22,6 +21,7 @@
>>  sysdeps/powerpc/powerpc32/power4
>>  sysdeps/powerpc/power4/fpu
>>  sysdeps/powerpc/power4
>> +sysdeps/powerpc/powerpc32/fpu
>>  sysdeps/powerpc/powerpc32
>>  sysdeps/wordsize-32
>>  sysdeps/powerpc/fpu
> That's not really enough context, given all the directories in between 
> that you don't show.  The real question is: are there any files in 
> sysdeps/powerpc/powerpc32/fpu that would previously have overridden a file 
> in any of the large number of intermediate directories, but no longer do 
> so after this patch?
>
Indeed I didn't supply much context information and the diff is not the best one.
Sorry about that and let me recapitulate: the initial POWER4/PPC32 multilib patch
removes the file sysdeps/unix/sysv/linux/powerpc/powerpc32/power4/Implies and this
is need to adjust the multiarch folders correctly.

For a POWER4 built, this change does:

--- sysdeps_original_ppc32
+++ sysdeps_before_ppc32
@@ -1,35 +1,35 @@
-sysdeps/unix/sysv/linux/powerpc/powerpc32/power4
-sysdeps/powerpc/powerpc32/power4/fpu
-sysdeps/powerpc/powerpc32/power4
-sysdeps/powerpc/power4/fpu
-sysdeps/powerpc/power4
 sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/nptl
 sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu
 sysdeps/powerpc/powerpc32/fpu
 nptl/sysdeps/unix/sysv/linux/powerpc/powerpc32
 sysdeps/unix/sysv/linux/powerpc/powerpc32
 nptl/sysdeps/unix/sysv/linux/powerpc
 sysdeps/unix/sysv/linux/powerpc
 nptl/sysdeps/unix/sysv/linux
 nptl/sysdeps/pthread
 sysdeps/pthread
 sysdeps/unix/sysv/linux
 sysdeps/gnu
 sysdeps/unix/inet
 nptl/sysdeps/unix/sysv
 sysdeps/unix/sysv
 sysdeps/unix/powerpc
 nptl/sysdeps/unix
 sysdeps/unix
 sysdeps/posix
+sysdeps/powerpc/powerpc32/power4/fpu
+sysdeps/powerpc/powerpc32/power4/multiarch
+sysdeps/powerpc/powerpc32/power4
+sysdeps/powerpc/power4/fpu
+sysdeps/powerpc/power4
 sysdeps/powerpc/powerpc32
 sysdeps/wordsize-32
 sysdeps/powerpc/fpu
 nptl/sysdeps/powerpc
 sysdeps/powerpc
 sysdeps/ieee754/ldbl-128ibm
 sysdeps/ieee754/ldbl-opt
 sysdeps/ieee754/dbl-64
 sysdeps/ieee754/flt-32
 sysdeps/ieee754

And it is the intended change: on x86_64 sysdeps/unix/sysv do have higher priority than
sysdeps/x86_64 folders.

Now, this patch is just to correct the missing 'sysdeps/powerpc' folder to appear in the
correct order as previously, before multiarch support:

--- sysdeps_before_ppc32
+++ sysdeps_after_ppc32
@@ -1,35 +1,35 @@
 sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/nptl
 sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu
-sysdeps/powerpc/powerpc32/fpu
 nptl/sysdeps/unix/sysv/linux/powerpc/powerpc32
 sysdeps/unix/sysv/linux/powerpc/powerpc32
 nptl/sysdeps/unix/sysv/linux/powerpc
 sysdeps/unix/sysv/linux/powerpc
 nptl/sysdeps/unix/sysv/linux
 nptl/sysdeps/pthread
 sysdeps/pthread
 sysdeps/unix/sysv/linux
 sysdeps/gnu
 sysdeps/unix/inet
 nptl/sysdeps/unix/sysv
 sysdeps/unix/sysv
 sysdeps/unix/powerpc
 nptl/sysdeps/unix
 sysdeps/unix
 sysdeps/posix
 sysdeps/powerpc/powerpc32/power4/fpu
 sysdeps/powerpc/powerpc32/power4/multiarch
 sysdeps/powerpc/powerpc32/power4
 sysdeps/powerpc/power4/fpu
 sysdeps/powerpc/power4
+sysdeps/powerpc/powerpc32/fpu
 sysdeps/powerpc/powerpc32
 sysdeps/wordsize-32
 sysdeps/powerpc/fpu
 nptl/sysdeps/powerpc
 sysdeps/powerpc
 sysdeps/ieee754/ldbl-128ibm
 sysdeps/ieee754/ldbl-opt
 sysdeps/ieee754/dbl-64
 sysdeps/ieee754/flt-32
 sysdeps/ieee754
 sysdeps/generic

And it indeeds makes more sense: the chip specific sysdeps/powerpc/powerpc32/power4/fpu and
sysdeps/powerpc/power4/fpu now have a higher prior than generic sysdeps/powerpc/powerpc32/fpu
(I considered only the fpu directories).

References:
- [PATCH 01/17] PowerPC: change sysdeps fpu folder
  - From: Adhemerval Zanella
- Re: [PATCH 01/17] PowerPC: change sysdeps fpu folder
  - From: Joseph S. Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]