This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] Add probe markers for sin, cos, asin and acos
- From: Andreas Jaeger <aj at suse dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>, libc-alpha at sourceware dot org
- Cc: Allan McRae <allan at archlinux dot org>
- Date: Tue, 19 Nov 2013 21:39:23 +0100
- Subject: Re: [PATCH 2/2] Add probe markers for sin, cos, asin and acos
- Authentication-results: sourceware.org; auth=none
- References: <20131025123854 dot GM23099 at spoyarek dot pnq dot redhat dot com> <526A680D dot 20405 at archlinux dot org> <CAAHN_R25QQYcNtakKNQd-svpitNvCKbddQoTDB8F1Ak8M_NKPg at mail dot gmail dot com> <20131028064947 dot GD1633 at spoyarek dot pnq dot redhat dot com>
On 10/28/2013 07:49 AM, Siddhesh Poyarekar wrote:
> On Fri, Oct 25, 2013 at 06:48:21PM +0530, Siddhesh Poyarekar wrote:
>> > On 25 October 2013 18:16, Allan McRae <allan@archlinux.org> wrote:
>>> > > You are doing more than add the probe here. I would have thought that
>>> > > clean-up would need to be a separate patch, or at least have a ChangeLog
>>> > > entry.
>> >
>> > OK, I'll split it up in my next iteration.
>
> ... and this is part two, which adds the probes.
>
> Siddhesh
>
> * manual/probes.texi (Mathematical Function Probes): Add
> documentation for sin, cos, asin and acos probes.
> * sysdeps/ieee754/dbl-64/sincos32.c: Include stap-probe.h.
> (__sin32): Add slowasin probe.
> (__cos32): Add slowacos probe.
> (__mpsin): Add slowsin probe.
> (__mpcos): Add slowcos probe.
Looks fine, thanks!
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126