This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [MTASCsft PATCH WIP5 01/33] Multi Thread, Async Signal and Async Cancel safety documentation: intro

On 11/18/2013 06:11 PM, Joseph S. Myers wrote:
> On Mon, 18 Nov 2013, Carlos O'Donell wrote:
>> On 11/13/2013 07:57 AM, Joseph S. Myers wrote:
>>> On Wed, 13 Nov 2013, Alexandre Oliva wrote:
>>>> +@item @code{simfpu}
>>>> +@cindex simfpu
>>>> +
>>>> +Functions annotated with @code{simfpu} may misbehave on powerpc ports in
>>>> +which the floating-point unit is disabled and floating point simulation
>>> Reviewing <>, 
>>> and <> on which 
>>> it depends, would be better than documenting the bug....
>> The adverb better should be associated with some kind of improvement
>> e.g. better that we have less defects instead of more detailed documentation.
>> While I agree that it is always better from a quality perspective to fix
>> bugs instead of documenting them, the problem is that Alex's goal here is
>> not to fix the bugs but to document several attributes for all functions
>> in the library.
> When considering a patch that we know is not the right solution to 
> something and parts of which are likely to need reverting as part of the 
> right solution, I think the relevant consideration is how soon that 
> reversion is likely to be needed.
> In this case, the proper solution already exists and so the reversion is 
> likely to be needed soon.  That is very different from the async signal 
> safe TLS patches, which could well largely be made obsolete by a proper 
> fix for bug 16134 (ensuring TLS allocation failure results in 
> pthread_create or dlopen failure) but where there is no indication of 
> anyone currently working on such a fix.

Point well made, but it's still open ended as to when you'll get the
patched committed into trunk. I don't want to presume that you'll do
this on any timeline, this is your time and your work.

Adhemerval just reviewed it this morning, and you've checked this in so
Alex now needs to remove the caveat about this.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]