This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/3] statxat: Add a system call to make extended file stats available
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: David Howells <dhowells at redhat dot com>
- Cc: viro at ZenIV dot linux dot org dot uk, linux-cifs at vger dot kernel dot org, linux-nfs at vger dot kernel dot org, libc-alpha at sourceware dot org, linux-api at vger dot kernel dot org, andreas dot gruenbacher at gmail dot com, samba-technical at lists dot samba dot org, linux-fsdevel at vger dot kernel dot org
- Date: Tue, 12 Nov 2013 19:44:59 +0100
- Subject: Re: [PATCH 2/3] statxat: Add a system call to make extended file stats available
- Authentication-results: sourceware.org; auth=none
- References: <20131112173518 dot 25813 dot 67568 dot stgit at warthog dot procyon dot org dot uk> <20131112173534 dot 25813 dot 70732 dot stgit at warthog dot procyon dot org dot uk>
David Howells <dhowells@redhat.com> writes:
> struct statx {
> uint32_t st_mask;
> uint32_t st_information;
> uint16_t st_mode;
> uint16_t __spare0[1];
> uint32_t st_nlink;
> uint32_t st_uid;
> uint32_t st_gid;
> uint32_t st_alloc_blksize;
> uint32_t st_blksize;
> uint32_t st_small_io_size;
> uint32_t st_large_io_size;
> struct statx_dev st_rdev;
> struct statx_dev st_dev;
> int32_t st_atime_ns;
> int32_t st_btime_ns;
> int32_t st_ctime_ns;
> int32_t st_mtime_ns;
> int64_t st_atime;
> int64_t st_btime;
> int64_t st_ctime;
> int64_t st_mtime;
> uint64_t st_ino;
> uint64_t st_size;
> uint64_t st_blocks;
> uint64_t st_version;
> uint64_t st_ioc_flags;
I'd suggest to use a different prefix (stx_ instead of st_) for the
members. st_[acm]time are typically defined as macros by <sys/stat.h>
which would conflict.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."