This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/3] statxat: Provide IOC flags for Windows fs attributes
- From: Steve French <smfrench at gmail dot com>
- To: David Howells <dhowells at redhat dot com>
- Cc: Al Viro <viro at zeniv dot linux dot org dot uk>, "linux-cifs at vger dot kernel dot org" <linux-cifs at vger dot kernel dot org>, "linux-nfs at vger dot kernel dot org" <linux-nfs at vger dot kernel dot org>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, "linux-api at vger dot kernel dot org" <linux-api at vger dot kernel dot org>, andreas dot gruenbacher at gmail dot com, samba-technical <samba-technical at lists dot samba dot org>, linux-fsdevel <linux-fsdevel at vger dot kernel dot org>
- Date: Tue, 12 Nov 2013 12:06:15 -0600
- Subject: Re: [PATCH 1/3] statxat: Provide IOC flags for Windows fs attributes
- Authentication-results: sourceware.org; auth=none
- References: <20131112173518 dot 25813 dot 67568 dot stgit at warthog dot procyon dot org dot uk> <20131112173526 dot 25813 dot 85546 dot stgit at warthog dot procyon dot org dot uk>
I was experimenting with these flags when adding the per-file
compression support for cifs and smb2/smb3, and noticed that it would
be helpful to be able to display the FILE_ATTRIBUTE_ENCRYPTED flag
here too on get (ie to show that the file is encrypted at rest on the
server). I am unsure whether displaying the "FILE_ATTRIBUTE_SPARSE"
is useful or not here but that is another obvious one.
And the other obvious flag to display would be
"FILE_ATTRIBUTE_INTEGRITY_STREAM" or equivalent (to indicate that this
file is protected by data and metadata checksums, perhaps btrfs and
other local file systems may even eventually allow you to configure
additional extra data/metadata integrity checks someday as well, not
just SMB3).
On Tue, Nov 12, 2013 at 11:35 AM, David Howells <dhowells@redhat.com> wrote:
> Provide IOC flags for Windows fs attributes so that they can be retrieved (or
> even altered) using the FS_IOC_[GS]ETFLAGS ioctl and read using statxat().
>
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
>
> include/uapi/linux/fs.h | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
> index 6c28b61bb690..8b966f48dd41 100644
> --- a/include/uapi/linux/fs.h
> +++ b/include/uapi/linux/fs.h
> @@ -191,10 +191,13 @@ struct inodes_stat_t {
> #define FS_EXTENT_FL 0x00080000 /* Extents */
> #define FS_DIRECTIO_FL 0x00100000 /* Use direct i/o */
> #define FS_NOCOW_FL 0x00800000 /* Do not cow file */
> +#define FS_HIDDEN_FL 0x10000000 /* Windows hidden file attribute */
> +#define FS_SYSTEM_FL 0x20000000 /* Windows system file attribute */
> +#define FS_ARCHIVE_FL 0x40000000 /* Windows archive file attribute */
> #define FS_RESERVED_FL 0x80000000 /* reserved for ext2 lib */
>
> -#define FS_FL_USER_VISIBLE 0x0003DFFF /* User visible flags */
> -#define FS_FL_USER_MODIFIABLE 0x000380FF /* User modifiable flags */
> +#define FS_FL_USER_VISIBLE 0x7003DFFF /* User visible flags */
> +#define FS_FL_USER_MODIFIABLE 0x700380FF /* User modifiable flags */
>
>
> #define SYNC_FILE_RANGE_WAIT_BEFORE 1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Thanks,
Steve