This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Ping Re: Fix localedef collation handling of <U0000> (bug 15948)
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: Roland McGrath <roland at hack dot frob dot com>, libc-alpha at sourceware dot org
- Date: Fri, 18 Oct 2013 20:40:22 +0200
- Subject: Re: Ping Re: Fix localedef collation handling of <U0000> (bug 15948)
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1309122206530 dot 28584 at digraph dot polyomino dot org dot uk> <20130924215529 dot 996342C099 at topped-with-meat dot com> <Pine dot LNX dot 4 dot 64 dot 1310032250390 dot 7552 at digraph dot polyomino dot org dot uk> <Pine dot LNX dot 4 dot 64 dot 1310101353330 dot 1661 at digraph dot polyomino dot org dot uk> <20131018093704 dot GA12068 at domone dot podge> <Pine dot LNX dot 4 dot 64 dot 1310181336380 dot 13831 at digraph dot polyomino dot org dot uk>
On Fri, Oct 18, 2013 at 01:40:06PM +0000, Joseph S. Myers wrote:
> On Fri, 18 Oct 2013, Ondrej Bilka wrote:
>
> > On Thu, Oct 10, 2013 at 01:53:47PM +0000, Joseph S. Myers wrote:
> > > Ping. This patch
> > > <https://sourceware.org/ml/libc-alpha/2013-10/msg00143.html> is pending
> > > review.
> > >
> > Where is testcase?
>
> The ar_SA.UTF-8 locale. Given the assertion (which I hope is obviously
> correct), it (and various other locales in glibc) gets an assertion
> failure on "make localedata/install-locales", the standard way of testing
> locales, in the absence of the substantive part of the patch. In the
> absence of the assertion, I don't have any user-visible failures caused by
> this memory allocation error (it was originally seen as user-visible when
> cross-building locales for m68k, but we decided to use 4-byte alignment in
> locales on all platforms rather than supporting cross-building locales to
> systems with 2-byte-aligned int, so that no longer applies).
>
Then patch is ok.