This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] HPPA/IA64 : Don't use broken DL_AUTO_FUNCTION_ADDRESS()

From: Guy Martin <gmsoft at tuxicoman dot be>
To: Andreas Schwab <schwab at linux-m68k dot org>
Cc: libc-alpha at sourceware dot org
Date: Fri, 18 Oct 2013 14:04:18 +0200
Subject: Re: [PATCH] HPPA/IA64 : Don't use broken DL_AUTO_FUNCTION_ADDRESS()
Authentication-results: sourceware.org; auth=none
References: <20131017214754 dot 00555bf3 at dellete> <871u3ina5t dot fsf at igel dot home>

On 2013-10-18 12:30, Andreas Schwab wrote:

Guy Martin <gmsoft@tuxicoman.be> writes:

To prevent this, we use instead the existing macro
DL_STATIC_FUNCTION_ADDRESS() which is identical to
DL_AUTO_FUNCTION_ADDRESS() but declares fptr as static.


Can the callers ever be reentered?

AFAICS, it can't. The macro using DL_STATIC_FUNCTION_ADDRESS() areDL_DT_INIT_ADDRESS() which is only used in dl-init.c andDL_DT_FINI_ADDRESS() used in dl-fini.c and dl-close.c.The only case where this might possibly be reentered would be parallelcalls of dlopen()/dlclose(). I'm not even sure those calls are supposedto be thread safe.

Guy

Follow-Ups:
- Re: [PATCH] HPPA/IA64 : Don't use broken DL_AUTO_FUNCTION_ADDRESS()
  - From: Mike Frysinger

References:
- [PATCH] HPPA/IA64 : Don't use broken DL_AUTO_FUNCTION_ADDRESS()
  - From: Guy Martin
- Re: [PATCH] HPPA/IA64 : Don't use broken DL_AUTO_FUNCTION_ADDRESS()
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]