This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC][PATCH] (Elision) Rename retry_try_xbegin to try_xbegin
- From: Dominik Vogt <vogt at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Cc: triegel at redhat dot com, andi at firstfloor dot org
- Date: Mon, 23 Sep 2013 09:56:22 +0200
- Subject: Re: [RFC][PATCH] (Elision) Rename retry_try_xbegin to try_xbegin
- Authentication-results: sourceware.org; auth=none
- References: <20130918113639 dot GA8139 at linux dot vnet dot ibm dot com> <1379682614 dot 10243 dot 3450 dot camel at triegel dot csb>
- Reply-to: libc-alpha at sourceware dot org
On Fri, Sep 20, 2013 at 03:10:14PM +0200, Torvald Riegel wrote:
> On Wed, 2013-09-18 at 13:36 +0200, Dominik Vogt wrote:
> > The attached patch renames retry_try_xbegin in the elision_config
> > structure to try_xbegin and fixes the source code documentation.
> > It is actually not the number of _re_tries but the total number of
> > attempts using elision before using the lock. The docuementation
> > suggested that (with the default values) one attempt plus three
> > retries would be made while in reality it were only three attempts
> > in total.
>
> This looks fine to me, provided you at least have built an x86-64 glibc
> with elision enabled.
Nope, I have only s390 machines here.
> However, I think the changelog should first state the change for
> elision-conf.h, and then use "...elision-conf.c: Likewise." for the
> other two files.
Like this?
2013-09-18 Dominik Vogt <vogt@linux.vnet.ibm.com>
* sysdeps/unix/sysv/linux/x86/elision-conf.h (struct elision_config):
Rename elision_config.retry_try_xbegin to try_xbegin
* sysdeps/unix/sysv/linux/x86/elision-lock.c (__lll_lock_elision):
Likewise.
* sysdeps/unix/sysv/linux/x86/elision-conf.c:
Likewise.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt
IBM Germany