This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]
Re: [COMMITTED][PATCH][BZ #15923]Update iso-1427.def and related occurrences.

From: Chris Leonard <cjlhomeaddress at gmail dot com>
To: Andreas Jaeger <aj at suse dot com>
Cc: libc-alpha <libc-alpha at sourceware dot org>
Date: Fri, 13 Sep 2013 08:26:00 -0400
Subject: Re: [COMMITTED][PATCH][BZ #15923]Update iso-1427.def and related occurrences.
Authentication-results: sourceware.org; auth=none
References: <CAHdAatYOdzNUHGJcToCuPdpiiGY+qy5UKDga+Xb6_Z7FZ8mr4w at mail dot gmail dot com>
In spite of having committed this change, I am still seeing an error
message from the ISO-4127 validator on my local machine.

[cjl@mycroft localedata]$ localedef  -i locales/ak_GH -c -f
charmaps/UTF-8 ./AK_GH.UTF-8
LC_MONETARY: value of field `int_curr_symbol' does not correspond to a
valid name in ISO 4217


Is this because I am running the test against the installed glibc and
not the local git glibc?  Would I have to complie glibc locally to get
the test to run cleanly?

Attached is the file for testing by anyone with a fresh locally complled glibc


On Wed, Sep 4, 2013 at 11:47 AM, Chris Leonard <cjlhomeaddress@gmail.com> wrote:
> Committed with requested adjustments.
>
> On Wed, Sep 4, 2013 at 3:58 AM, Andreas Jaeger <aj@suse.com> wrote:
>> On 09/03/2013 01:15 AM, Chris Leonard wrote:
>>> Discovered that I couldn't validate a locale for Ghana due to a
>>> failure of an LC_MONETARY check of ISO-4127.  Tracked it down to an
>>> invalid validator, this fixes that one as well as others and related
>>> occurrences.
>>>
>>>
>>> ./ChangeLog
>>>
>>> 2013-09-02  Chris Leonard  <cjl@sugarlabs,.org>
>>>
>>>     [BZ #15923]
>>>     * locale/iso-4217.def: Update iso-1427.def and related occurrences.
>>>
>>>
>>> ./localedata/ChangeLog
>>>
>>> 2013-09-02  Chris Leonard  <cjl@sugarlabs,.org>
>>>
>>>     [BZ #15923]
>>
>> When you commit this, update NEWS as well.
>>
>>>     * localedata/locales/ar_SD: Update iso-1427.def and related occurrences.
>>>     * localedata/locales/az_AZ: Update iso-1427.def and related occurrences.
>>>     * localedata/locales/dv_MV: Update iso-1427.def and related occurrences.
>>>     * localedata/locales/es_VE: Update iso-1427.def and related occurrences.
>>
>> Remove the localedata prefix for changes to localedata/ChangeLog
>>
>> The patch is fine, thanks,
>> Andreas
>>
>>>
>>>
>>> ---
>>>  locale/iso-4217.def      | 24 ++++++++----------------
>>>  localedata/locales/ar_SD |  3 ++-
>>>  localedata/locales/az_AZ |  3 ++-
>>>  localedata/locales/dv_MV |  2 +-
>>>  localedata/locales/es_VE |  3 ++-
>>>  5 files changed, 15 insertions(+), 20 deletions(-)
>>>
>>> diff --git a/locale/iso-4217.def b/locale/iso-4217.def
>>> index ee01339..bcc170b 100644
>>> --- a/locale/iso-4217.def
>>> +++ b/locale/iso-4217.def
>>> @@ -17,7 +17,7 @@ DEFINE_INT_CURR("AOA")        /* Angolan Kwanza  */
>>>  DEFINE_INT_CURR("ARS")        /* Argentine Peso  */
>>>  DEFINE_INT_CURR("AUD")        /* Australian Dollar  */
>>>  DEFINE_INT_CURR("AWG")        /* Aruba Guilder  */
>>> -DEFINE_INT_CURR("AZM")        /* Azerbaijan Manat  */
>>> +DEFINE_INT_CURR("AZN")        /* Azerbaijan Manat  */
>>>  DEFINE_INT_CURR("BAM")        /* Bosnian and Herzegovina Convertible Mark  */
>>>  DEFINE_INT_CURR("BBD")        /* Barbados Dollar  */
>>>  DEFINE_INT_CURR("BDT")        /* Bangladesh Taka  */
>>> @@ -27,7 +27,7 @@ DEFINE_INT_CURR("BIF")        /* Burundi Franc  */
>>>  DEFINE_INT_CURR("BMD")        /* Burmudian Dollar  */
>>>  DEFINE_INT_CURR("BND")        /* Brunei Dollar  */
>>>  DEFINE_INT_CURR("BOB")        /* Bolivian Boliviano  */
>>> -DEFINE_INT_CURR("BRL")        /* Brazil Cruzeiro  */
>>> +DEFINE_INT_CURR("BRL")        /* Brazil Real  */
>>>  DEFINE_INT_CURR("BSD")        /* Bahamas Dollar  */
>>>  DEFINE_INT_CURR("BTN")        /* Bhutan Ngultrum  */
>>>  DEFINE_INT_CURR("BWP")        /* Botswana Pula  */
>>> @@ -57,7 +57,7 @@ DEFINE_INT_CURR("FJD")        /* Fiji Dollar  */
>>>  DEFINE_INT_CURR("FKP")        /* Falkland Islands Pound (Malvinas)  */
>>>  DEFINE_INT_CURR("GBP")        /* British Pound  */
>>>  DEFINE_INT_CURR("GEL")        /* Georgia Lari  */
>>> -DEFINE_INT_CURR("GHC")        /* Ghana Cedi  */
>>> +DEFINE_INT_CURR("GHS")        /* Ghana Cedi  */
>>>  DEFINE_INT_CURR("GIP")        /* Gibraltar Pound  */
>>>  DEFINE_INT_CURR("GMD")        /* Gambian Dalasi  */
>>>  DEFINE_INT_CURR("GNF")        /* Guinea Franc  */
>>> @@ -70,12 +70,10 @@ DEFINE_INT_CURR("HTG")        /* Haiti Gourde  */
>>>  DEFINE_INT_CURR("HUF")        /* Hungarian Forint  */
>>>  DEFINE_INT_CURR("IDR")        /* Indonesia Rupiah  */
>>>  DEFINE_INT_CURR("ILS")        /* Israeli Shekel  */
>>> -DEFINE_INT_CURR("IMP")        /* Isle of Man Pounds  */
>>>  DEFINE_INT_CURR("INR")        /* Indian Rupee (Bhutan)  */
>>>  DEFINE_INT_CURR("IQD")        /* Iraqi Dinar  */
>>>  DEFINE_INT_CURR("IRR")        /* Iranian Rial  */
>>>  DEFINE_INT_CURR("ISK")        /* Iceland Krona  */
>>> -DEFINE_INT_CURR("JEP")        /* Jersey Pound  */
>>>  DEFINE_INT_CURR("JMD")        /* Jamaican Dollar  */
>>>  DEFINE_INT_CURR("JOD")        /* Jordanian Dinar  */
>>>  DEFINE_INT_CURR("JPY")        /* Japanese Yen  */
>>> @@ -106,11 +104,11 @@ DEFINE_INT_CURR("MOP")        /* Macau Pataca  */
>>>  DEFINE_INT_CURR("MRO")        /* Mauritania Ouguiya  */
>>>  DEFINE_INT_CURR("MTL")        /* Maltese Lira  */
>>>  DEFINE_INT_CURR("MUR")        /* Mauritius Rupee  */
>>> -DEFINE_INT_CURR("MVR")        /* Maldives Rupee  */
>>> +DEFINE_INT_CURR("MVR")        /* Maldives Rufiyaa  */
>>>  DEFINE_INT_CURR("MWK")        /* Malawi Kwacha  */
>>>  DEFINE_INT_CURR("MXN")        /* Mexican Peso  */
>>>  DEFINE_INT_CURR("MYR")        /* Malaysian Ringgit  */
>>> -DEFINE_INT_CURR("MZM")        /* Mozambique Metical  */
>>> +DEFINE_INT_CURR("MZN")        /* Mozambique Metical  */
>>>  DEFINE_INT_CURR("NAD")        /* Namibia Dollar  */
>>>  DEFINE_INT_CURR("NGN")        /* Nigeria Naira  */
>>>  DEFINE_INT_CURR("NIO")        /* Nicaragua Cordoba Oro  */
>>> @@ -126,7 +124,6 @@ DEFINE_INT_CURR("PKR")        /* Pakistan Rupee  */
>>>  DEFINE_INT_CURR("PLN")        /* Polish Zloty  */
>>>  DEFINE_INT_CURR("PYG")        /* Paraguay Guarani  */
>>>  DEFINE_INT_CURR("QAR")        /* Qatar Rial  */
>>> -DEFINE_INT_CURR("ROL")        /* Romanian Leu  */
>>>  DEFINE_INT_CURR("RON")        /* Romanian New Leu  */
>>>  DEFINE_INT_CURR("RSD")        /* Serbian Dinars  */
>>>  DEFINE_INT_CURR("RUB")        /* Russian Ruble  */
>>> @@ -134,16 +131,13 @@ DEFINE_INT_CURR("RWF")        /* Rwanda Franc  */
>>>  DEFINE_INT_CURR("SAR")        /* Saudi Arabia Riyal  */
>>>  DEFINE_INT_CURR("SBD")        /* Solomon Islands Dollar  */
>>>  DEFINE_INT_CURR("SCR")        /* Seychelles Rupee  */
>>> -DEFINE_INT_CURR("SDD")        /* Sudanese Dinars  */
>>> +DEFINE_INT_CURR("SDG")        /* Sudanese Pound  */
>>>  DEFINE_INT_CURR("SEK")        /* Swedish Krona  */
>>>  DEFINE_INT_CURR("SGD")        /* Singapore Dollar  */
>>>  DEFINE_INT_CURR("SHP")        /* St. Helena Pound  */
>>> -DEFINE_INT_CURR("SIT")        /* Slovenian Tolar  */
>>> -DEFINE_INT_CURR("SKK")        /* Slovakian Koruna  */
>>>  DEFINE_INT_CURR("SLL")        /* Sierra Leone Leone  */
>>>  DEFINE_INT_CURR("SOS")        /* Somalia Schilling  */
>>> -DEFINE_INT_CURR("SPL")        /* Seborga Luigini  */
>>> -DEFINE_INT_CURR("SRG")        /* Suriname Guilder  */
>>> +DEFINE_INT_CURR("SRD")        /* Suriname Dollar  */
>>>  DEFINE_INT_CURR("STD")        /* Sao Tome and Principe Dobra  */
>>>  DEFINE_INT_CURR("SVC")        /* El Salvador Colon  */
>>>  DEFINE_INT_CURR("SYP")        /* Syrian Arab Republic Pound  */
>>> @@ -155,7 +149,6 @@ DEFINE_INT_CURR("TND")        /* Tunisian Dinar  */
>>>  DEFINE_INT_CURR("TOP")        /* Tonga Pa'Anga  */
>>>  DEFINE_INT_CURR("TRY")        /* New Turkish Lira  */
>>>  DEFINE_INT_CURR("TTD")        /* Trinidad and Tobago  */
>>> -DEFINE_INT_CURR("TVD")        /* Tuvalu Dollars  */
>>>  DEFINE_INT_CURR("TWD")        /* Taiwan, Province of China Dollar  */
>>>  DEFINE_INT_CURR("TZS")        /* United Republic of Tanzania Shilling  */
>>>  DEFINE_INT_CURR("UAH")        /* Ukraine Hryvna  */
>>> @@ -163,13 +156,12 @@ DEFINE_INT_CURR("UGX")        /* Ugandan Shilling  */
>>>  DEFINE_INT_CURR("USD")        /* United States Dollar  */
>>>  DEFINE_INT_CURR("UYU")        /* Uruguay Peso Uruguayo  */
>>>  DEFINE_INT_CURR("UZS")        /* Uzbekistan Sum  */
>>> -DEFINE_INT_CURR("VEB")        /* Venezuelan Bolivar  */
>>> +DEFINE_INT_CURR("VEF")        /* Venezuelan Bolivar Fuerte */
>>>  DEFINE_INT_CURR("VND")        /* Viet Nam Dong  */
>>>  DEFINE_INT_CURR("VUV")        /* Vanuatu Vatu  */
>>>  DEFINE_INT_CURR("WST")        /* Samoa Tala  */
>>>  DEFINE_INT_CURR("XAF")        /* Central African Franc (United
>>> Republic of Cameroon, Central African Republic, Chad, Congo, Gabon)
>>> */
>>>  DEFINE_INT_CURR("XCD")        /* East Caribbean Dollar (Antiqua,
>>> Dominica, Grenada, Montserrat, St. Kitts-Nevis-Anguilla, Saint Lucia,
>>> Saint Vincent and the Grenadines)  */
>>> -DEFINE_INT_CURR("XDR")        /* International Monetary Fund  */
>>>  DEFINE_INT_CURR("XOF")        /* West African Franc (Benin, Ivory
>>> Coast, Niger, Senegal, Togo, Upper Volta)  */
>>>  DEFINE_INT_CURR("XPF")        /* French polynesia, New Caledonia,
>>> Wallis and Futuna Islands  */
>>>  DEFINE_INT_CURR("YER")        /* Yemeni Rial  */
>>> diff --git a/localedata/locales/ar_SD b/localedata/locales/ar_SD
>>> index c4a2f86..452a795 100644
>>> --- a/localedata/locales/ar_SD
>>> +++ b/localedata/locales/ar_SD
>>> @@ -47,7 +47,8 @@ LC_MONETARY
>>>  % These are generated based on XML base Locale definition file
>>>  % for IBM Class for Unicode/Java
>>>  %
>>> -int_curr_symbol       "<U0053><U0044><U0044><U0020>"
>>> +% SDG
>>> +int_curr_symbol       "<U0053><U0044><U0047><U0020>"
>>>  currency_symbol       "<U062C><U002E><U0633><U002E>"
>>>  mon_decimal_point     "<U002E>"
>>>  mon_thousands_sep     "<U002C>"
>>> diff --git a/localedata/locales/az_AZ b/localedata/locales/az_AZ
>>> index 24e3779..4a8b270 100644
>>> --- a/localedata/locales/az_AZ
>>> +++ b/localedata/locales/az_AZ
>>> @@ -207,7 +207,8 @@ noexpr
>>> "<U005E><U005B><U0059><U0079><U004E><U006E><U005D><U002E><U002A>"
>>>  END LC_MESSAGES
>>>
>>>  LC_MONETARY
>>> -int_curr_symbol           "<U0041><U005A><U004D><U0020>"
>>> +% AZN
>>> +int_curr_symbol           "<U0041><U005A><U004E><U0020>"
>>>  currency_symbol           "<U006D><U0061><U006E><U002E>"
>>>  mon_decimal_point         "<U002E>"
>>>  mon_thousands_sep         "<U0020>"
>>> diff --git a/localedata/locales/dv_MV b/localedata/locales/dv_MV
>>> index 064da13..91ca8b1 100644
>>> --- a/localedata/locales/dv_MV
>>> +++ b/localedata/locales/dv_MV
>>> @@ -55,7 +55,7 @@ copy "en_DK"
>>>  END LC_COLLATE
>>>
>>>  LC_MONETARY
>>> -% it is meant to be MVR, could you see if it is correct please
>>> +% MVR
>>>  int_curr_symbol "<U004D><U0056><U0052><U0020>"
>>>  currency_symbol "<U0783><U002E>"
>>>  mon_decimal_point "<U002E>"
>>> diff --git a/localedata/locales/es_VE b/localedata/locales/es_VE
>>> index 1ec2dff..b8596bb 100644
>>> --- a/localedata/locales/es_VE
>>> +++ b/localedata/locales/es_VE
>>> @@ -60,7 +60,8 @@ copy "es_ES"
>>>  END LC_MESSAGES
>>>
>>>  LC_MONETARY
>>> -int_curr_symbol      "<U0056><U0045><U0042><U0020>"
>>> +% VEF
>>> +int_curr_symbol      "<U0056><U0045><U0046><U0020>"
>>>  currency_symbol      "<U0042><U0073><U002E>"
>>>  mon_decimal_point    "<U002C>"
>>>  mon_thousands_sep    "<U002E>"
>>>
>>
>>
>> --
>>  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
>>   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>>    GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
>>     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126
Attachment: ak_GH
Description: Binary data
Follow-Ups:
- Re: [COMMITTED][PATCH][BZ #15923]Update iso-1427.def and related occurrences.
  - From: Andreas Schwab
References:
- Re: [COMMITTED][PATCH][BZ #15923]Update iso-1427.def and related occurrences.
  - From: Chris Leonard
Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]