This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] sunrpc/rpc/types.h: Fix OS X build problem.
- From: Jia Liu <proljc at gmail dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 5 Sep 2013 21:24:34 +0800
- Subject: Re: [PATCH] sunrpc/rpc/types.h: Fix OS X build problem.
- Authentication-results: sourceware.org; auth=none
- References: <1378366884-29968-1-git-send-email-proljc at gmail dot com> <874n9zd1tj dot fsf at igel dot home>
Hi Andreas,
On Thu, Sep 5, 2013 at 6:01 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Jia Liu <proljc@gmail.com> writes:
>
>> When I build arm-linux-gcc on OS X, I find glibc will get a build error
>> in sunrpc/rpc/types.h, so I add __APPLE_CC__ to make OS X build OK.
>>
>> ChangeLog:
>>
>> 2013-09-05 Jia Liu <proljc@gmail.com>
>>
>> * sunrpc/rpc/types.h (__APPLE_CC__): New variable.
>
> This is wrong, you are not defining the macro here, you are using it.
> Write this:
>
> * sunrpc/rpc/types.h [__APPLE_CC__]: Don't define u_char, etc.
>
Thank you, I will change it in V2.
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
Regards,
Jia