This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add AARCH64 relocation constants to elf/elf.h


On Aug 30, 2013, at 10:52 AM, "Carlos O'Donell" <carlos@redhat.com> wrote:

> On 08/29/2013 08:12 PM, Petr Machata wrote:
>> Roland McGrath <roland@hack.frob.com> writes:
>> 
>>> If the names are still in flux, then I think we're better off waiting to
>>> add any names that might change, rather than adding them now and changing
>>> them later.
>> 
>> The names that will be changed have already been added to elf.h in the
>> past.  I don't include the renaming (of those existing constants) in my
>> patch, as the normative document is not yet out.
> 
> Your patch also does some whitespace changes that should not be in the same
> patch as one that adds or renames new constants.
> 
> If we have to rename constants I'd like to see two patches, one that adds
> constants, and another that renames.
> 
> I'd also prefer strongly to wait for the normative document to be published
> by ARM, but that doesn't mean you can't have a branch ready with this patch
> so we can cherry-pick it in immediately.

I am almost ready to submit a patch which depends on the renaming due to the patch adding support for ilp32 abi. I would like the renaming patch to go in before mine.  I don't know what arm's schedule to release the abi document though.

Thanks,
Andrew Pinski


> 
> Cheers,
> Carlos.
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]