This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi! On Wed, 29 May 2013 15:01:40 -0700 (PDT), Roland McGrath <roland@hack.frob.com> wrote: > > First, my "usual" cleanup patch: > > > > * sysdeps/unix/sysv/linux/ldsodefs.h (VALID_ELF_OSABI) > > (VALID_ELF_ABIVERSION, MORE_ELF_HEADER_DATA): Use ELFOSABI_GNU > > instead of ELFOSABI_LINUX. > > > > ports/ChangeLog.arm > > * sysdeps/unix/sysv/linux/arm/ldsodefs.h (VALID_ELF_OSABI) > > (MORE_ELF_HEADER_DATA): Use ELFOSABI_GNU instead of ELFOSABI_LINUX. > > > > ports/ChangeLog.mips > > * sysdeps/unix/sysv/linux/mips/ldsodefs.h (VALID_ELF_ABIVERSION): > > Use ELFOSABI_GNU instead of ELFOSABI_LINUX. > > This is fine. Pushed as commit c54290cf086940e3859b236d0fb880bacab2288b. > > I suggest we instead implement this in sysdeps/gnu/ldsodefs.h, as this is > > a common GNU thing. > > That is a good thing to do. > > > Tested on x86 and x86_64 GNU/Linux, and x86 GNU/Hurd; glibc testsuite as > > well as manually as follows: > > Verify on x86_64-linux-gnu that the change has no effect whatsoever on the > compiled code. Had done this back then. > > * sysdeps/unix/sysv/linux/ldsodefs.h (VALID_ELF_HEADER) > > (VALID_ELF_OSABI, VALID_ELF_ABIVERSION, MORE_ELF_HEADER_DATA): > > Move macros to... > > * sysdeps/gnu/ldsodefs.h: ... this new file. > > With that verified, this is fine. Pushed as commit d821f07c9e9575b47df87cc38f26c31e09b3ce0d. GrÃÃe, Thomas
Attachment:
pgpLiTTOPw8nD.pgp
Description: PGP signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |