This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2 v1.1][BZ #14547] Fix CVE-2012-4412
- From: Andreas Schwab <schwab at suse dot de>
- To: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- Cc: OndÅej BÃlka <neleai at seznam dot cz>, Siddhesh Poyarekar <siddhesh at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 26 Aug 2013 10:10:33 +0200
- Subject: Re: [PATCH 2/2 v1.1][BZ #14547] Fix CVE-2012-4412
- Authentication-results: sourceware.org; auth=none
- References: <20130630164500 dot GF2654 at spoyarek dot pnq dot redhat dot com> <mvmehagsfhm dot fsf at hawking dot suse dot de> <20130821151403 dot GB15273 at spoyarek dot pnq dot redhat dot com> <20130821160808 dot GA4369 at domone dot kolej dot mff dot cuni dot cz> <CAAHN_R2UwiuNAXyqv7QvZzkbfy7vqAMn1EQ-ka82OFUogChVvQ at mail dot gmail dot com> <20130824062248 dot GA16906 at domone dot kolej dot mff dot cuni dot cz> <CAAHN_R2UYzo+N3gcPjUzmkQFOBj6mmKZ2hbHbJW9cfeFthXw7A at mail dot gmail dot com>
Siddhesh Poyarekar <siddhesh.poyarekar@gmail.com> writes:
> On 24 August 2013 11:52, OndÅej BÃlka <neleai@seznam.cz> wrote:
>>> It eliminates nesting and makes code easier to read. Not all goto is evil.
>>>
>> Not all but this is. If you do not want nesting use following:
>
> Since you're not going to give a valid reason for your belief, I'm
> just going to state that I like my goto approach better because it
> looks less silly to me compared to a blank if block.
I prefer the goto-free form as well.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."